core/src/fxcrt/fx_arabic.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_arabic.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: core/src/fxcrt/fx_arabic.h

diff --git a/core/src/fxcrt/fx_arabic.h b/core/src/fxcrt/fx_arabic.h

index e4c1ddacf244ad65d4769c32921a7d1e816252cf..10a16afa6341d8a224bce736952dc25983811a20 100644

--- a/core/src/fxcrt/fx_arabic.h

+++ b/core/src/fxcrt/fx_arabic.h

@@ -15,14 +15,14 @@ public:

CFX_BidiChar();

~CFX_BidiChar() override {}

- void SetPolicy(FX_BOOL bSeparateNeutral = TRUE) override;

- FX_BOOL AppendChar(FX_WCHAR wch) override;

- FX_BOOL EndChar() override;

+ void SetPolicy(bool bSeparateNeutral = true) override;

+ bool AppendChar(FX_WCHAR wch) override;

+ bool EndChar() override;

int32_t GetBidiInfo(int32_t &iStart, int32_t &iCount) override;

void Reset() override;

private:

- FX_BOOL m_bSeparateNeutral;

+ bool m_bSeparateNeutral;

int32_t m_iCurStart;

int32_t m_iCurCount;

int32_t m_iCurBidi;

« no previous file with comments | « core/src/fxcrt/extension.h ('k') | core/src/fxcrt/fx_arabic.cpp » ('j') | no next file with comments »