FX_BOOL considered harmful.

fpdfsdk/include/pdfwindow/PWL_EditCtrl.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_INCLUDE_PDFWINDOW_PWL_EDITCTRL_H_
 #define FPDFSDK_INCLUDE_PDFWINDOW_PWL_EDITCTRL_H_
 
 #include "../../../core/include/fxcrt/fx_string.h"
@@ skipping 50 matching lines @@
         friend class CPWL_Edit_Notify;
 
 public:
         CPWL_EditCtrl();
         virtual ~CPWL_EditCtrl();
 
 public:
         virtual void                                    OnCreate(PWL_CREATEPARAM & cp);
         virtual void                                    OnCreated();
 
-        virtual FX_BOOL                                 OnKeyDown(FX_WORD nChar, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnChar(FX_WORD nChar, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnMouseMove(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnKeyDown(FX_WORD nChar, FX_DWORD nFlag);
+        virtual bool                                    OnChar(FX_WORD nChar, FX_DWORD nFlag);
+        virtual bool                                    OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnMouseMove(const CPDF_Point & point, FX_DWORD nFlag);
         virtual void                                    OnNotify(CPWL_Wnd* pWnd, FX_DWORD msg, intptr_t wParam = 0, intptr_t lParam = 0);
 
         virtual void                                    CreateChildWnd(const PWL_CREATEPARAM & cp);
         virtual void                                    RePosChildWnd();
         virtual void                                    SetFontSize(FX_FLOAT fFontSize);
         virtual FX_FLOAT                                GetFontSize() const;
 
 public:
         virtual void                                    SetText(const FX_WCHAR* csText);
 
         virtual void                                    CopyText();
         virtual void                                    PasteText();
         virtual void                                    CutText();
 
         CPDF_Rect                                               GetContentRect() const;
         void                                                    GetCaretPos(int32_t& x, int32_t& y) const;
-        FX_BOOL                                                 IsModified() const;
+        bool                                                    IsModified() const;
 
         CFX_WideString                                  GetText() const;
         void                                                    SetSel(int32_t nStartChar,int32_t nEndChar);
         void                                                    GetSel(int32_t & nStartChar, int32_t & nEndChar ) const;
         void                                                    GetTextRange(const CPDF_Rect& rect, int32_t & nStartChar, int32_t & nEndChar) const;
         CFX_WideString                                  GetText(int32_t & nStartChar, int32_t & nEndChar) const;
         void                                                    Clear();
         void                                                    SelectAll();
 
         int32_t                                         GetCaret() const;
         void                                                    SetCaret(int32_t nPos);
         int32_t                                         GetTotalWords() const;
 
         void                                                    Paint();
 
-        void                                                    EnableRefresh(FX_BOOL bRefresh);
+        void                                                    EnableRefresh(bool bRefresh);
         CPDF_Point                                              GetScrollPos() const;
         void                                                    SetScrollPos(const CPDF_Point& point);
 
         void                                                    SetEditNotify(IPWL_Edit_Notify* pNotify) {m_pEditNotify = pNotify;}
 
         void                                                    SetCharSet(uint8_t nCharSet){m_nCharSet = nCharSet;}
         int32_t                                         GetCharSet() const;
 
         void                                                    SetCodePage(int32_t nCodePage){m_nCodePage = nCodePage;}
         int32_t                                         GetCodePage() const {return m_nCodePage;}
 
         CPDF_Font *                                             GetCaretFont() const;
         FX_FLOAT                                                GetCaretFontSize() const;
 
-        FX_BOOL                                                 CanUndo() const;
-        FX_BOOL                                                 CanRedo() const;
+        bool                                                    CanUndo() const;
+        bool                                                    CanRedo() const;
         void                                                    Redo();
         void                                                    Undo();
 
         void                                                    SetReadyToInput();
 protected:
-        virtual void                                    ShowVScrollBar(FX_BOOL bShow);
+        virtual void                                    ShowVScrollBar(bool bShow);
 
         virtual void                                    InsertWord(FX_WORD word, int32_t nCharset);
         virtual void                                    InsertReturn();
         virtual void                                    InsertText(const FX_WCHAR* csText);
 
         virtual void                                    SetCursor();
-        FX_BOOL                                                 IsWndHorV();
+        bool                                                    IsWndHorV();
 
         void                                                    Delete();
         void                                                    Backspace();
 
 protected:
         void                                                    GetCaretInfo(CPDF_Point & ptHead, CPDF_Point & ptFoot) const;
-        void                                                    SetCaret(FX_BOOL bVisible, const CPDF_Point & ptHead, const CPDF_Point & ptFoot);
+        void                                                    SetCaret(bool bVisible, const CPDF_Point & ptHead, const CPDF_Point & ptFoot);
 
-        void                                                    SetEditCaret(FX_BOOL bVisible);
+        void                                                    SetEditCaret(bool bVisible);
 
 protected:
         virtual void                                    IOnSetScrollInfoX(FX_FLOAT fPlateMin, FX_FLOAT fPlateMax,
                                                                                                 FX_FLOAT fContentMin, FX_FLOAT fContentMax,
                                                                                                 FX_FLOAT fSmallStep, FX_FLOAT fBigStep){}
         virtual void                                    IOnSetScrollInfoY(FX_FLOAT fPlateMin, FX_FLOAT fPlateMax,
                                                                                                 FX_FLOAT fContentMin, FX_FLOAT fContentMax,
                                                                                                 FX_FLOAT fSmallStep, FX_FLOAT fBigStep);
         virtual void                                    IOnSetScrollPosX(FX_FLOAT fx){}
         virtual void                                    IOnSetScrollPosY(FX_FLOAT fy);
-        virtual void                                    IOnSetCaret(FX_BOOL bVisible,const CPDF_Point & ptHead,const CPDF_Point & ptFoot, const CPVT_WordPlace& place);
+        virtual void                                    IOnSetCaret(bool bVisible,const CPDF_Point & ptHead,const CPDF_Point & ptFoot, const CPVT_WordPlace& place);
         virtual void                                    IOnCaretChange(const CPVT_SecProps & secProps, const CPVT_WordProps & wordProps);
         virtual void                                    IOnContentChange(const CPDF_Rect& rcContent);
         virtual void                                    IOnInvalidateRect(CPDF_Rect * pRect);
 
 private:
         void                                                    CreateEditCaret(const PWL_CREATEPARAM & cp);
 
 protected:
         IFX_Edit*                                               m_pEdit;
         CPWL_Caret*                                             m_pEditCaret;
-        FX_BOOL                                                 m_bMouseDown;
+        bool                                                    m_bMouseDown;
         IPWL_Edit_Notify*                               m_pEditNotify;
 
 private:
         int32_t                                         m_nCharSet;
         int32_t                                         m_nCodePage;
 };
 
 #endif  // FPDFSDK_INCLUDE_PDFWINDOW_PWL_EDITCTRL_H_