FX_BOOL considered harmful.

core/include/fpdfapi/fpdf_module.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_MODULE_H_
 #define CORE_INCLUDE_FPDFAPI_FPDF_MODULE_H_
 
 #include "../../../third_party/base/nonstd_unique_ptr.h"
@@ skipping 42 matching lines @@
     }
     CCodec_ModuleMgr* GetCodecModule()
     {
         return m_pCodecModule;
     }
 
     void InitPageModule();
 
     void InitRenderModule();
 
-    void SetDownloadCallback(FX_BOOL (*callback)(const FX_CHAR* module_name));
+    void SetDownloadCallback(bool (*callback)(const FX_CHAR* module_name));
 
-    FX_BOOL DownloadModule(const FX_CHAR* module_name);
+    bool DownloadModule(const FX_CHAR* module_name);
 
     void NotifyModuleAvailable(const FX_CHAR* module_name);
 
     IPDF_RenderModule* GetRenderModule() const
     {
         return m_pRenderModule.get();
     }
 
     IPDF_PageModule* GetPageModule() const
     {
@@ skipping 27 matching lines @@
 
 private:
     CPDF_ModuleMgr();
     ~CPDF_ModuleMgr();
 
     CCodec_ModuleMgr* m_pCodecModule;
 
     nonstd::unique_ptr<IPDF_RenderModule> m_pRenderModule;
     nonstd::unique_ptr<IPDF_PageModule> m_pPageModule;
 
-    FX_BOOL (*m_pDownloadCallback)(const FX_CHAR* module_name);
+    bool (*m_pDownloadCallback)(const FX_CHAR* module_name);
 
     CFX_MapByteStringToPtr m_SecurityHandlerMap;
 
     CFX_PrivateData m_privateData;
 };
 
 class IPDF_PageModule
 {
 public:
     virtual ~IPDF_PageModule() {}
@@ skipping 15 matching lines @@
     virtual CPDF_DocRenderData* CreateDocData(CPDF_Document* pDoc) = 0;
     virtual void DestroyDocData(CPDF_DocRenderData*) = 0;
     virtual void ClearDocData(CPDF_DocRenderData*) = 0;
     virtual CPDF_DocRenderData* GetRenderData() = 0;
     virtual CPDF_PageRenderCache* CreatePageCache(CPDF_Page* pPage) = 0;
     virtual void DestroyPageCache(CPDF_PageRenderCache*)  = 0;
     virtual CPDF_RenderConfig* GetConfig() = 0;
 };
 
 #endif  // CORE_INCLUDE_FPDFAPI_FPDF_MODULE_H_