FX_BOOL considered harmful.

core/src/fxcrt/fx_basic_util.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fxcrt/fx_basic.h"
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
 #include <sys/types.h>
 #include <dirent.h>
 #else
 #include <direct.h>
 #endif
 CFX_PrivateData::~CFX_PrivateData()
 {
     ClearAll();
 }
 void FX_PRIVATEDATA::FreeData()
 {
     if (m_pData == NULL) {
         return;
     }
     if (m_bSelfDestruct) {
         delete (CFX_DestructObject*)m_pData;
     } else if (m_pCallback) {
         m_pCallback(m_pData);
     }
 }
-void CFX_PrivateData::AddData(void* pModuleId, void* pData, PD_CALLBACK_FREEDATA callback, FX_BOOL bSelfDestruct)
+void CFX_PrivateData::AddData(void* pModuleId, void* pData, PD_CALLBACK_FREEDATA callback, bool bSelfDestruct)
 {
     if (pModuleId == NULL) {
         return;
     }
     FX_PRIVATEDATA* pList = m_DataList.GetData();
     int count = m_DataList.GetSize();
     for (int i = 0; i < count; i ++) {
         if (pList[i].m_pModuleId == pModuleId) {
             pList[i].FreeData();
             pList[i].m_pData = pData;
             pList[i].m_pCallback = callback;
             return;
         }
     }
     FX_PRIVATEDATA data = {pModuleId, pData, callback, bSelfDestruct};
     m_DataList.Add(data);
 }
 void CFX_PrivateData::SetPrivateData(void* pModuleId, void* pData, PD_CALLBACK_FREEDATA callback)
 {
-    AddData(pModuleId, pData, callback, FALSE);
+    AddData(pModuleId, pData, callback, false);
 }
 void CFX_PrivateData::SetPrivateObj(void* pModuleId, CFX_DestructObject* pObj)
 {
-    AddData(pModuleId, pObj, NULL, TRUE);
+    AddData(pModuleId, pObj, NULL, true);
 }
-FX_BOOL CFX_PrivateData::RemovePrivateData(void* pModuleId)
+bool CFX_PrivateData::RemovePrivateData(void* pModuleId)
 {
     if (pModuleId == NULL) {
-        return FALSE;
+        return false;
     }
     FX_PRIVATEDATA* pList = m_DataList.GetData();
     int count = m_DataList.GetSize();
     for (int i = 0; i < count; i ++) {
         if (pList[i].m_pModuleId == pModuleId) {
             m_DataList.RemoveAt(i);
-            return TRUE;
+            return true;
         }
     }
-    return FALSE;
+    return false;
 }
 void* CFX_PrivateData::GetPrivateData(void* pModuleId)
 {
     if (pModuleId == NULL) {
         return NULL;
     }
     FX_PRIVATEDATA* pList = m_DataList.GetData();
     int count = m_DataList.GetSize();
     for (int i = 0; i < count; i ++) {
         if (pList[i].m_pModuleId == pModuleId) {
             return pList[i].m_pData;
         }
     }
     return NULL;
 }
 void CFX_PrivateData::ClearAll()
 {
     FX_PRIVATEDATA* pList = m_DataList.GetData();
     int count = m_DataList.GetSize();
     for (int i = 0; i < count; i ++) {
         pList[i].FreeData();
     }
     m_DataList.RemoveAll();
 }
-void FX_atonum(const CFX_ByteStringC& strc, FX_BOOL& bInteger, void* pData)
+void FX_atonum(const CFX_ByteStringC& strc, bool& bInteger, void* pData)
 {
     if (FXSYS_memchr(strc.GetPtr(), '.', strc.GetLength()) == NULL) {
-        bInteger = TRUE;
+        bInteger = true;
         int cc = 0, integer = 0;
         const FX_CHAR* str = strc.GetCStr();
         int len = strc.GetLength();
-        FX_BOOL bNegative = FALSE;
+        bool bNegative = false;
         if (str[0] == '+') {
             cc++;
         } else if (str[0] == '-') {
-            bNegative = TRUE;
+            bNegative = true;
             cc++;
         }
         while (cc < len) {
             if (str[cc] < '0' || str[cc] > '9') {
                 break;
             }
             integer = integer * 10 + str[cc] - '0';
             if (integer < 0) {
                 break;
             }
             cc ++;
         }
         if (bNegative) {
             integer = -integer;
         }
         *(int*)pData = integer;
     } else {
-        bInteger = FALSE;
+        bInteger = false;
         *(FX_FLOAT*)pData = FX_atof(strc);
     }
 }
 FX_FLOAT FX_atof(const CFX_ByteStringC& strc)
 {
     if (strc.GetLength() == 0) {
         return 0.0;
     }
     int cc = 0;
-    FX_BOOL bNegative = FALSE;
+    bool bNegative = false;
     const FX_CHAR* str = strc.GetCStr();
     int len = strc.GetLength();
     if (str[0] == '+') {
         cc++;
     } else if (str[0] == '-') {
-        bNegative = TRUE;
+        bNegative = true;
         cc++;
     }
     while (cc < len) {
         if (str[cc] != '+' && str[cc] != '-') {
             break;
         }
         cc ++;
     }
     FX_FLOAT value = 0;
     while (cc < len) {
@@ skipping 31 matching lines @@
 }
 void FXSYS_vsnprintf(char *str, size_t size, const char* fmt, va_list ap)
 {
     (void) _vsnprintf(str, size, fmt, ap);
     if (size) {
         str[size - 1] = 0;
     }
 }
 #endif  // _FXM_PLATFORM_WINDOWS_ && _MSC_VER < 1900
 
-static FX_BOOL FX_IsDigit(uint8_t ch)
+static bool FX_IsDigit(uint8_t ch)
 {
-    return (ch >= '0' && ch <= '9') ? TRUE : FALSE;
+    return (ch >= '0' && ch <= '9') ? true : false;
 }
-static FX_BOOL FX_IsXDigit(uint8_t ch)
+static bool FX_IsXDigit(uint8_t ch)
 {
-    return (FX_IsDigit(ch) || (ch >= 'A' && ch <= 'F') || (ch >= 'a' && ch <= 'f')) ? TRUE : FALSE;
+    return (FX_IsDigit(ch) || (ch >= 'A' && ch <= 'F') || (ch >= 'a' && ch <= 'f')) ? true : false;
 }
 static uint8_t FX_MakeUpper(uint8_t ch)
 {
     if (ch < 'a' || ch > 'z') {
         return ch;
     }
     return ch - 32;
 }
 static int FX_HexToI(uint8_t ch)
 {
@@ skipping 85 matching lines @@
         }
     }
     return CFX_WideString::FromUTF8(rURI, rURI.GetLength());
 }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
 class CFindFileData
 {
 public:
     virtual ~CFindFileData() {}
     HANDLE                              m_Handle;
-    FX_BOOL                             m_bEnd;
+    bool                                m_bEnd;
 };
 class CFindFileDataA : public CFindFileData
 {
 public:
     virtual ~CFindFileDataA() {}
     WIN32_FIND_DATAA    m_FindData;
 };
 class CFindFileDataW : public CFindFileData
 {
 public:
@@ skipping 12 matching lines @@
     pData->m_Handle = FindFirstFileExA(CFX_ByteString(path) + "/*.*", FindExInfoStandard, &pData->m_FindData, FindExSearchNameMatch, NULL, 0);
 #endif
 #else
     CFindFileDataW* pData = new CFindFileDataW;
     pData->m_Handle = FindFirstFileW(CFX_WideString::FromLocal(path) + L"/*.*", &pData->m_FindData);
 #endif
     if (pData->m_Handle == INVALID_HANDLE_VALUE) {
         delete pData;
         return NULL;
     }
-    pData->m_bEnd = FALSE;
+    pData->m_bEnd = false;
     return pData;
 #else
     DIR* dir = opendir(path);
     return dir;
 #endif
 }
 void* FX_OpenFolder(const FX_WCHAR* path)
 {
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
     CFindFileDataW* pData = new CFindFileDataW;
 #ifdef _FX_WINAPI_PARTITION_DESKTOP_
     pData->m_Handle = FindFirstFileW((CFX_WideString(path) + L"/*.*").c_str(), &pData->m_FindData);
 #else
     pData->m_Handle = FindFirstFileExW((CFX_WideString(path) + L"/*.*").c_str(), FindExInfoStandard, &pData->m_FindData, FindExSearchNameMatch, NULL, 0);
 #endif
     if (pData->m_Handle == INVALID_HANDLE_VALUE) {
         delete pData;
         return NULL;
     }
-    pData->m_bEnd = FALSE;
+    pData->m_bEnd = false;
     return pData;
 #else
     DIR* dir = opendir(CFX_ByteString::FromUnicode(path));
     return dir;
 #endif
 }
-FX_BOOL FX_GetNextFile(void* handle, CFX_ByteString& filename, FX_BOOL& bFolder)
+bool FX_GetNextFile(void* handle, CFX_ByteString& filename, bool& bFolder)
 {
     if (handle == NULL) {
-        return FALSE;
+        return false;
     }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
 #ifndef _WIN32_WCE
     CFindFileDataA* pData = (CFindFileDataA*)handle;
     if (pData->m_bEnd) {
-        return FALSE;
+        return false;
     }
     filename = pData->m_FindData.cFileName;
     bFolder = pData->m_FindData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY;
     if (!FindNextFileA(pData->m_Handle, &pData->m_FindData)) {
-        pData->m_bEnd = TRUE;
+        pData->m_bEnd = true;
     }
-    return TRUE;
+    return true;
 #else
     CFindFileDataW* pData = (CFindFileDataW*)handle;
     if (pData->m_bEnd) {
-        return FALSE;
+        return false;
     }
     filename = CFX_ByteString::FromUnicode(pData->m_FindData.cFileName);
     bFolder = pData->m_FindData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY;
     if (!FindNextFileW(pData->m_Handle, &pData->m_FindData)) {
-        pData->m_bEnd = TRUE;
+        pData->m_bEnd = true;
     }
-    return TRUE;
+    return true;
 #endif
 #elif defined(__native_client__)
     abort();
-    return FALSE;
+    return false;
 #else
     struct dirent *de = readdir((DIR*)handle);
     if (de == NULL) {
-        return FALSE;
+        return false;
     }
     filename = de->d_name;
     bFolder = de->d_type == DT_DIR;
-    return TRUE;
+    return true;
 #endif
 }
-FX_BOOL FX_GetNextFile(void* handle, CFX_WideString& filename, FX_BOOL& bFolder)
+bool FX_GetNextFile(void* handle, CFX_WideString& filename, bool& bFolder)
 {
     if (handle == NULL) {
-        return FALSE;
+        return false;
     }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
     CFindFileDataW* pData = (CFindFileDataW*)handle;
     if (pData->m_bEnd) {
-        return FALSE;
+        return false;
     }
     filename = pData->m_FindData.cFileName;
     bFolder = pData->m_FindData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY;
     if (!FindNextFileW(pData->m_Handle, &pData->m_FindData)) {
-        pData->m_bEnd = TRUE;
+        pData->m_bEnd = true;
     }
-    return TRUE;
+    return true;
 #elif defined(__native_client__)
     abort();
-    return FALSE;
+    return false;
 #else
     struct dirent *de = readdir((DIR*)handle);
     if (de == NULL) {
-        return FALSE;
+        return false;
     }
     filename = CFX_WideString::FromLocal(de->d_name);
     bFolder = de->d_type == DT_DIR;
-    return TRUE;
+    return true;
 #endif
 }
 void FX_CloseFolder(void* handle)
 {
     if (handle == NULL) {
         return;
     }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
     CFindFileData* pData = (CFindFileData*)handle;
     FindClose(pData->m_Handle);
@@ skipping 46 matching lines @@
 }
 
 CFX_Vector_3by1 CFX_Matrix_3by3::TransformVector(const CFX_Vector_3by1 &v)
 {
     return CFX_Vector_3by1(
         a * v.a + b * v.b + c * v.c,
         d * v.a + e * v.b + f * v.c,
         g * v.a + h * v.b + i * v.c
     );
 }