FX_BOOL considered harmful.

fpdfsdk/include/pdfwindow/PWL_Wnd.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_INCLUDE_PDFWINDOW_PWL_WND_H_
 #define FPDFSDK_INCLUDE_PDFWINDOW_PWL_WND_H_
 
 #include "../../../core/include/fxcrt/fx_basic.h"
@@ skipping 119 matching lines @@
         /*
         COLORTYPE_TRANSPARENT
         COLORTYPE_RGB
         COLORTYPE_CMYK
         COLORTYPE_GRAY
         */
         int32_t                                 nColorType;
         FX_FLOAT                                        fColor1,fColor2,fColor3,fColor4;
 };
 
-inline FX_BOOL operator == (const CPWL_Color &c1, const CPWL_Color &c2)
+inline bool operator == (const CPWL_Color &c1, const CPWL_Color &c2)
 {
         return c1.nColorType == c2.nColorType &&
                 c1.fColor1 - c2.fColor1 < 0.0001 && c1.fColor1 - c2.fColor1 > -0.0001 &&
                 c1.fColor2 - c2.fColor2 < 0.0001 && c1.fColor2 - c2.fColor2 > -0.0001 &&
                 c1.fColor3 - c2.fColor3 < 0.0001 && c1.fColor3 - c2.fColor3 > -0.0001 &&
                 c1.fColor4 - c2.fColor4 < 0.0001 && c1.fColor4 - c2.fColor4 > -0.0001;
 }
 
-inline FX_BOOL operator != (const CPWL_Color &c1, const CPWL_Color &c2)
+inline bool operator != (const CPWL_Color &c1, const CPWL_Color &c2)
 {
         return !operator == (c1, c2);
 }
 
 #define PWL_SCROLLBAR_WIDTH                                     12.0f
 #define PWL_SCROLLBAR_BUTTON_WIDTH                      9.0f
 #define PWL_SCROLLBAR_POSBUTTON_MINWIDTH        2.0f
 #define PWL_SCROLLBAR_TRANSPARANCY                      150
 #define PWL_SCROLLBAR_BKCOLOR                           CPWL_Color(COLORTYPE_RGB,220.0f/255.0f,220.0f/255.0f,220.0f/255.0f)
 #define PWL_DEFAULT_SELTEXTCOLOR                        CPWL_Color(COLORTYPE_RGB,1,1,1)
 #define PWL_DEFAULT_SELBACKCOLOR                        CPWL_Color(COLORTYPE_RGB,0,51.0f/255.0f,113.0f/255.0f)
 #define PWL_DEFAULT_BACKCOLOR                           PWL_DEFAULT_SELTEXTCOLOR
 #define PWL_DEFAULT_TEXTCOLOR                           CPWL_Color(COLORTYPE_RGB,0,0,0)
 #define PWL_DEFAULT_FONTSIZE                            9.0f
 #define PWL_DEFAULT_BLACKCOLOR                          CPWL_Color(COLORTYPE_GRAY,0)
 #define PWL_DEFAULT_WHITECOLOR                          CPWL_Color(COLORTYPE_GRAY,1)
 #define PWL_DEFAULT_HEAVYGRAYCOLOR                      CPWL_Color(COLORTYPE_GRAY,0.50)
 #define PWL_DEFAULT_LIGHTGRAYCOLOR                      CPWL_Color(COLORTYPE_GRAY,0.75)
 #define PWL_TRIANGLE_HALFLEN                            2.0f
 #define PWL_CBBUTTON_TRIANGLE_HALFLEN           3.0f
 #define PWL_INVALIDATE_INFLATE                          2
 
 class IPWL_SpellCheck
 {
 public:
         virtual ~IPWL_SpellCheck() { }
-        virtual FX_BOOL                                                 CheckWord(const FX_CHAR* sWord) = 0;
+        virtual bool                                                    CheckWord(const FX_CHAR* sWord) = 0;
         virtual void                                                    SuggestWords(const FX_CHAR* sWord, CFX_ByteStringArray & sSuggest) = 0;
 };
 
 class IPWL_Provider
 {
 public:
         virtual ~IPWL_Provider() { }
 
         //get a matrix which map user space to CWnd client space
         virtual CPDF_Matrix                                             GetWindowMatrix(void* pAttachedData) = 0;
@@ skipping 104 matching lines @@
 class PWL_CLASS CPWL_Wnd : public CPWL_TimerHandler
 {
         friend class CPWL_MsgControl;
 public:
         CPWL_Wnd();
         virtual ~CPWL_Wnd();
 
         void                                                    Create(const PWL_CREATEPARAM & cp);
         virtual CFX_ByteString                  GetClassName() const;
         void                                                    Destroy();
-        void                                                    Move(const CPDF_Rect & rcNew,FX_BOOL bReset,FX_BOOL bRefresh);
+        void                                                    Move(const CPDF_Rect & rcNew,bool bReset,bool bRefresh);
         virtual void                                    InvalidateRect(CPDF_Rect* pRect = NULL);
 
         void                                                    GetAppearanceStream(CFX_ByteString & sAppStream);
         void                                                    DrawAppearance(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device);
 
-        virtual FX_BOOL                                 OnKeyDown(FX_WORD nChar, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnKeyUp(FX_WORD nChar, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnChar(FX_WORD nChar, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnLButtonDblClk(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnMButtonDblClk(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnMButtonDown(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnMButtonUp(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnRButtonDown(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnRButtonUp(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnMouseMove(const CPDF_Point & point, FX_DWORD nFlag);
-        virtual FX_BOOL                                 OnMouseWheel(short zDelta, const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnKeyDown(FX_WORD nChar, FX_DWORD nFlag);
+        virtual bool                                    OnKeyUp(FX_WORD nChar, FX_DWORD nFlag);
+        virtual bool                                    OnChar(FX_WORD nChar, FX_DWORD nFlag);
+        virtual bool                                    OnLButtonDblClk(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnMButtonDblClk(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnMButtonDown(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnMButtonUp(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnRButtonDown(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnRButtonUp(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnMouseMove(const CPDF_Point & point, FX_DWORD nFlag);
+        virtual bool                                    OnMouseWheel(short zDelta, const CPDF_Point & point, FX_DWORD nFlag);
 
         virtual void                                    SetFocus();
         virtual void                                    KillFocus();
         void                                                    SetCapture();
         void                                                    ReleaseCapture();
 
         virtual void                                    OnNotify(CPWL_Wnd* pWnd, FX_DWORD msg, intptr_t wParam = 0, intptr_t lParam = 0);
         virtual void                                    SetTextColor(const CPWL_Color & color);
         virtual void                                    SetTextStrokeColor(const CPWL_Color & color);
-        virtual void                                    SetVisible(FX_BOOL bVisible);
+        virtual void                                    SetVisible(bool bVisible);
 
         virtual CPDF_Rect                               GetFocusRect() const;
         virtual CPWL_Color                              GetBackgroundColor() const;
         virtual CPWL_Color                              GetBorderColor() const;
         virtual CPWL_Color                              GetTextColor() const;
         virtual CPWL_Color                              GetTextStrokeColor() const;
         virtual FX_FLOAT                                GetFontSize() const;
         virtual int32_t                         GetInnerBorderWidth() const;
         virtual CPWL_Color                              GetBorderLeftTopColor(int32_t nBorderStyle) const;
         virtual CPWL_Color                              GetBorderRightBottomColor(int32_t nBorderStyle) const;
 
-        virtual FX_BOOL                                 IsModified() const {return FALSE;}
+        virtual bool                                    IsModified() const {return false;}
 
         virtual void                                    SetFontSize(FX_FLOAT fFontSize);
 
         void                                                    SetBackgroundColor(const CPWL_Color & color);
         void                                                    SetBorderColor(const CPWL_Color & color);
         void                                                    SetBorderWidth(int32_t nBorderWidth);
         void                                                    SetClipRect(const CPDF_Rect & rect);
         void                                                    SetBorderStyle(int32_t eBorderStyle);
         void                                                    SetBorderDash(const CPWL_Dash & sDash);
 
         CPDF_Rect                                               GetOriginWindowRect() const;
         virtual CPDF_Rect                               GetWindowRect() const;
         virtual CPDF_Rect                               GetClientRect() const;
         CPDF_Point                                              GetCenterPoint() const;
         CPDF_Rect                                               GetClientCenterSquare() const;
         CPDF_Rect                                               GetWindowCenterSquare() const;
         int32_t                                         GetBorderWidth() const;
-        FX_BOOL                                                 IsVisible() const {return m_bVisible;}
-        FX_BOOL                                                 HasFlag(FX_DWORD dwFlags) const;
+        bool                                                    IsVisible() const {return m_bVisible;}
+        bool                                                    HasFlag(FX_DWORD dwFlags) const;
         void                                                    AddFlag(FX_DWORD dwFlags);
         void                                                    RemoveFlag(FX_DWORD dwFlags);
         CPDF_Rect                                               GetClipRect() const;
         CPWL_Wnd*                                               GetParentWindow() const;
         int32_t                                         GetBorderStyle() const;
         CPWL_Dash                                               GetBorderDash() const;
         void*                                                   GetAttachedData() const;
 
-        FX_BOOL                                                 WndHitTest(const CPDF_Point & point) const;
-        FX_BOOL                                                 ClientHitTest(const CPDF_Point & point) const;
-        FX_BOOL                                                 IsCaptureMouse() const;
+        bool                                                    WndHitTest(const CPDF_Point & point) const;
+        bool                                                    ClientHitTest(const CPDF_Point & point) const;
+        bool                                                    IsCaptureMouse() const;
 
         const CPWL_Wnd*                                 GetFocused() const;
-        FX_BOOL                                                 IsFocused() const;
-        FX_BOOL                                                 IsReadOnly() const;
+        bool                                                    IsFocused() const;
+        bool                                                    IsReadOnly() const;
         CPWL_ScrollBar*                                 GetVScrollBar() const;
 
         IFX_Edit_FontMap*                               GetFontMap() const;
         IPWL_Provider*                                  GetProvider() const;
         virtual IFX_SystemHandler*              GetSystemHandler() const;
         IPWL_FocusHandler*                              GetFocusHandler() const;
 
         int32_t                                         GetTransparency();
         void                                                    SetTransparency(int32_t nTransparency);
 
         CPDF_Matrix                                             GetChildToRoot() const;
         CPDF_Matrix                                             GetChildMatrix() const;
         void                                                    SetChildMatrix(const CPDF_Matrix& mt);
         CPDF_Matrix                                             GetWindowMatrix() const;
 
         virtual CPDF_Point                              ChildToParent(const CPDF_Point& point) const;
         virtual CPDF_Rect                               ChildToParent(const CPDF_Rect& rect) const;
         virtual CPDF_Point                              ParentToChild(const CPDF_Point& point) const;
         virtual CPDF_Rect                               ParentToChild(const CPDF_Rect& rect) const;
 
         //those methods only implemented by listctrl item
         virtual FX_FLOAT                                GetItemHeight(FX_FLOAT fLimitWidth) {return 0;}
         virtual FX_FLOAT                                GetItemLeftMargin() {return 0;}
         virtual FX_FLOAT                                GetItemRightMargin() {return 0;}
 
-        void                                                    EnableWindow(FX_BOOL bEnable);
-        FX_BOOL                                                 IsEnabled();
+        void                                                    EnableWindow(bool bEnable);
+        bool                                                    IsEnabled();
         virtual void                                    SetCursor();
 
 protected:
         virtual void                                    CreateChildWnd(const PWL_CREATEPARAM & cp);
         virtual void                                    RePosChildWnd();
         void                                                    GetAppearanceStream(CFX_ByteTextBuf & sAppStream);
         virtual void                                    GetThisAppearanceStream(CFX_ByteTextBuf & sAppStream);
         virtual void                                    GetChildAppearanceStream(CFX_ByteTextBuf & sAppStream);
 
         virtual void                                    DrawThisAppearance(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device);
         virtual void                                    DrawChildAppearance(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device);
 
         virtual void                                    OnCreate(PWL_CREATEPARAM & cp);
         virtual void                                    OnCreated();
         virtual void                                    OnDestroy();
 
         virtual void                                    OnSetFocus();
         virtual void                                    OnKillFocus();
 
         virtual void                                    OnEnabled();
         virtual void                                    OnDisabled();
 
-        void                                                    SetNotifyFlag(FX_BOOL bNotifying = TRUE){m_bNotifying = bNotifying;};
+        void                                                    SetNotifyFlag(bool bNotifying = true){m_bNotifying = bNotifying;};
 
-        FX_BOOL                                                 IsValid() const;
+        bool                                                    IsValid() const;
         PWL_CREATEPARAM                                 GetCreationParam() const;
-        FX_BOOL                                                 IsNotifying() const {return m_bNotifying;}
+        bool                                                    IsNotifying() const {return m_bNotifying;}
 
         void                                                    InvalidateRectMove(const CPDF_Rect & rcOld, const CPDF_Rect & rcNew);
 
         void                                                    PWLtoWnd(const CPDF_Point & point, int32_t& x, int32_t& y) const;
         FX_RECT                                                 PWLtoWnd(const CPDF_Rect & rect) const;
         FX_HWND                                                 GetAttachedHWnd() const;
 
-        FX_BOOL                                                 IsWndCaptureMouse(const CPWL_Wnd * pWnd) const;
-        FX_BOOL                                                 IsWndCaptureKeyboard(const CPWL_Wnd * pWnd) const;
+        bool                                                    IsWndCaptureMouse(const CPWL_Wnd * pWnd) const;
+        bool                                                    IsWndCaptureKeyboard(const CPWL_Wnd * pWnd) const;
         const CPWL_Wnd*                                 GetRootWnd() const;
 
-        FX_BOOL                                                 IsCTRLpressed(FX_DWORD nFlag) const;
-        FX_BOOL                                                 IsSHIFTpressed(FX_DWORD nFlag) const;
-        FX_BOOL                                                 IsALTpressed(FX_DWORD nFlag) const;
-        FX_BOOL                                                 IsINSERTpressed(FX_DWORD nFlag) const;
+        bool                                                    IsCTRLpressed(FX_DWORD nFlag) const;
+        bool                                                    IsSHIFTpressed(FX_DWORD nFlag) const;
+        bool                                                    IsALTpressed(FX_DWORD nFlag) const;
+        bool                                                    IsINSERTpressed(FX_DWORD nFlag) const;
 
 private:
         void                                                    AddChild(CPWL_Wnd * pWnd);
         void                                                    RemoveChild(CPWL_Wnd * pWnd);
 
         void                                                    CreateScrollBar(const PWL_CREATEPARAM & cp);
         void                                                    CreateVScrollBar(const PWL_CREATEPARAM & cp);
 
         void                                                    AjustStyle();
         void                                                    CreateMsgControl();
         void                                                    DestroyMsgControl();
 
         CPWL_MsgControl*                                GetMsgControl() const;
 
 protected:
         CFX_ArrayTemplate<CPWL_Wnd*>    m_aChildren;
 
 private:
         PWL_CREATEPARAM                                 m_sPrivateParam;
 
         CPWL_ScrollBar*                                 m_pVScrollBar;
 
         CPDF_Rect                                               m_rcWindow;
         CPDF_Rect                                               m_rcClip;
 
-        FX_BOOL                                                 m_bCreated;
-        FX_BOOL                                                 m_bVisible;
-        FX_BOOL                                                 m_bNotifying;
-        FX_BOOL                                                 m_bEnabled;
+        bool                                                    m_bCreated;
+        bool                                                    m_bVisible;
+        bool                                                    m_bNotifying;
+        bool                                                    m_bEnabled;
 };
 
 #endif  // FPDFSDK_INCLUDE_PDFWINDOW_PWL_WND_H_