FX_BOOL considered harmful.

core/include/fpdfdoc/fpdf_vt.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFDOC_FPDF_VT_H_
 #define CORE_INCLUDE_FPDFDOC_FPDF_VT_H_
 
 #include "../fpdfapi/fpdf_parser.h"
@@ skipping 21 matching lines @@
         nSecIndex = other_nSecIndex;
         nLineIndex = other_nLineIndex;
         nWordIndex = other_nWordIndex;
     }
 
     void Default()
     {
         nSecIndex = nLineIndex = nWordIndex = -1;
     }
 
-    FX_BOOL operator == (const CPVT_WordPlace & wp) const
+    bool operator == (const CPVT_WordPlace & wp) const
     {
         return wp.nSecIndex == nSecIndex && wp.nLineIndex == nLineIndex && wp.nWordIndex == nWordIndex;
     }
 
-    FX_BOOL operator != (const CPVT_WordPlace & wp) const
+    bool operator != (const CPVT_WordPlace & wp) const
     {
         return wp.nSecIndex != nSecIndex || wp.nLineIndex != nLineIndex || wp.nWordIndex != nWordIndex;
     }
 
     inline int32_t WordCmp(const CPVT_WordPlace & wp) const
     {
         if (nSecIndex > wp.nSecIndex) {
             return 1;
         }
         if (nSecIndex < wp.nSecIndex) {
@@ skipping 77 matching lines @@
         BeginPos = begin;
         SwapWordPlace();
     }
 
     void SetEndPos(const CPVT_WordPlace & end)
     {
         EndPos = end;
         SwapWordPlace();
     }
 
-    FX_BOOL IsExist() const
+    bool IsExist() const
     {
         return BeginPos != EndPos;
     }
 
-    FX_BOOL operator != (const CPVT_WordRange & wr) const
+    bool operator != (const CPVT_WordRange & wr) const
     {
         return wr.BeginPos != BeginPos || wr.EndPos != EndPos;
     }
 
     void SwapWordPlace()
     {
         if (BeginPos.WordCmp(EndPos) > 0) {
             CPVT_WordPlace place = EndPos;
             EndPos = BeginPos;
             BeginPos = place;
@@ skipping 122 matching lines @@
     virtual ~IPDF_VariableText_Provider() { }
 
     virtual int32_t                                             GetCharWidth(int32_t nFontIndex, FX_WORD word, int32_t nWordStyle) = 0;
 
     virtual int32_t                                             GetTypeAscent(int32_t nFontIndex) = 0;
 
     virtual int32_t                                             GetTypeDescent(int32_t nFontIndex) = 0;
 
     virtual int32_t                                             GetWordFontIndex(FX_WORD word, int32_t charset, int32_t nFontIndex) = 0;
 
-    virtual FX_BOOL                                                     IsLatinWord(FX_WORD word) = 0;
+    virtual bool                                                        IsLatinWord(FX_WORD word) = 0;
 
     virtual int32_t                                             GetDefaultFontIndex() = 0;
 };
 class IPDF_VariableText_Iterator
 {
 public:
     virtual ~IPDF_VariableText_Iterator() { }
 
-    virtual FX_BOOL                                                     NextWord() = 0;
+    virtual bool                                                        NextWord() = 0;
 
-    virtual FX_BOOL                                                     PrevWord() = 0;
+    virtual bool                                                        PrevWord() = 0;
 
-    virtual FX_BOOL                                                     NextLine() = 0;
+    virtual bool                                                        NextLine() = 0;
 
-    virtual FX_BOOL                                                     PrevLine() = 0;
+    virtual bool                                                        PrevLine() = 0;
 
-    virtual FX_BOOL                                                     NextSection() = 0;
+    virtual bool                                                        NextSection() = 0;
 
-    virtual FX_BOOL                                                     PrevSection() = 0;
+    virtual bool                                                        PrevSection() = 0;
 
-    virtual FX_BOOL                                                     GetWord(CPVT_Word & word) const = 0;
+    virtual bool                                                        GetWord(CPVT_Word & word) const = 0;
 
-    virtual FX_BOOL                                                     SetWord(const CPVT_Word & word) = 0;
+    virtual bool                                                        SetWord(const CPVT_Word & word) = 0;
 
-    virtual FX_BOOL                                                     GetLine(CPVT_Line & line) const = 0;
+    virtual bool                                                        GetLine(CPVT_Line & line) const = 0;
 
-    virtual FX_BOOL                                                     GetSection(CPVT_Section & section) const = 0;
+    virtual bool                                                        GetSection(CPVT_Section & section) const = 0;
 
-    virtual     FX_BOOL                                                 SetSection(const CPVT_Section & section) = 0;
+    virtual     bool                                                    SetSection(const CPVT_Section & section) = 0;
 
     virtual void                                                        SetAt(int32_t nWordIndex) = 0;
 
     virtual void                                                        SetAt(const CPVT_WordPlace & place) = 0;
 
     virtual const CPVT_WordPlace &                      GetAt() const = 0;
 };
 class IPDF_VariableText
 {
 public:
@@ skipping 12 matching lines @@
     virtual void                                                        SetPasswordChar(FX_WORD wSubWord = '*') = 0;
 
     virtual void                                                        SetLimitChar(int32_t nLimitChar = 0) = 0;
 
     virtual void                                                        SetCharArray(int32_t nCharArray = 0) = 0;
 
     virtual void                                                        SetCharSpace(FX_FLOAT fCharSpace = 0.0f) = 0;
 
     virtual void                                                        SetHorzScale(int32_t nHorzScale = 100) = 0;
 
-    virtual void                                                        SetMultiLine(FX_BOOL bMultiLine = TRUE) = 0;
+    virtual void                                                        SetMultiLine(bool bMultiLine = true) = 0;
 
-    virtual void                                                        SetAutoReturn(FX_BOOL bAuto = TRUE) = 0;
+    virtual void                                                        SetAutoReturn(bool bAuto = true) = 0;
 
-    virtual void                                                        SetAutoFontSize(FX_BOOL bAuto = TRUE) = 0;
+    virtual void                                                        SetAutoFontSize(bool bAuto = true) = 0;
 
     virtual void                                                        SetFontSize(FX_FLOAT fFontSize) = 0;
 
     virtual void                                                        SetLineLeading(FX_FLOAT fLineLeading) = 0;
 
-    virtual void                                                        SetRichText(FX_BOOL bRichText) = 0;
+    virtual void                                                        SetRichText(bool bRichText) = 0;
 
     virtual void                                                        Initialize() = 0;
 
-    virtual FX_BOOL                                                     IsValid() const = 0;
+    virtual bool                                                        IsValid() const = 0;
 
-    virtual FX_BOOL                                                     IsRichText() const = 0;
+    virtual bool                                                        IsRichText() const = 0;
 
     virtual void                                                        RearrangeAll() = 0;
 
     virtual void                                                        RearrangePart(const CPVT_WordRange & PlaceRange) = 0;
 
     virtual void                                                        ResetAll() = 0;
 
     virtual void                                                        SetText(const FX_WCHAR* text, int32_t charset = 1, const CPVT_SecProps * pSecProps = NULL,
             const CPVT_WordProps * pWordProps = NULL) = 0;
 
@@ skipping 21 matching lines @@
     virtual FX_FLOAT                                            GetFontSize() const = 0;
 
     virtual int32_t                                             GetAlignment() const = 0;
 
     virtual FX_WORD                                                     GetPasswordChar() const = 0;
 
     virtual int32_t                                             GetCharArray() const = 0;
 
     virtual int32_t                                             GetLimitChar() const = 0;
 
-    virtual FX_BOOL                                                     IsMultiLine() const = 0;
+    virtual bool                                                        IsMultiLine() const = 0;
 
     virtual int32_t                                             GetHorzScale() const = 0;
 
     virtual FX_FLOAT                                            GetCharSpace() const = 0;
 
     virtual CPVT_WordPlace                                      GetBeginWordPlace() const = 0;
 
     virtual CPVT_WordPlace                                      GetEndWordPlace() const = 0;
 
     virtual CPVT_WordPlace                                      GetPrevWordPlace(const CPVT_WordPlace & place) const = 0;
 
     virtual CPVT_WordPlace                                      GetNextWordPlace(const CPVT_WordPlace & place) const = 0;
 
     virtual CPVT_WordPlace                                      SearchWordPlace(const CPDF_Point & point) const = 0;
 
     virtual CPVT_WordPlace                                      GetUpWordPlace(const CPVT_WordPlace & place, const CPDF_Point & point) const = 0;
 
     virtual CPVT_WordPlace                                      GetDownWordPlace(const CPVT_WordPlace & place, const CPDF_Point & point) const = 0;
 
     virtual CPVT_WordPlace                                      GetLineBeginPlace(const CPVT_WordPlace & place) const = 0;
 
     virtual CPVT_WordPlace                                      GetLineEndPlace(const CPVT_WordPlace & place) const = 0;
 
     virtual CPVT_WordPlace                                      GetSectionBeginPlace(const CPVT_WordPlace & place) const = 0;
 
     virtual CPVT_WordPlace                                      GetSectionEndPlace(const CPVT_WordPlace & place) const = 0;
 
     virtual void                                                        UpdateWordPlace(CPVT_WordPlace & place) const = 0;
 
-    virtual CPVT_WordPlace                                      AjustLineHeader(const CPVT_WordPlace & place, FX_BOOL bPrevOrNext) const = 0;
+    virtual CPVT_WordPlace                                      AjustLineHeader(const CPVT_WordPlace & place, bool bPrevOrNext) const = 0;
 
     virtual int32_t                                             WordPlaceToWordIndex(const CPVT_WordPlace & place) const = 0;
 
     virtual CPVT_WordPlace                                      WordIndexToWordPlace(int32_t index) const = 0;
 
 protected:
     ~IPDF_VariableText() { }
 };
 
 #endif  // CORE_INCLUDE_FPDFDOC_FPDF_VT_H_