FX_BOOL considered harmful.

core/include/fpdfapi/fpdf_pageobj.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_PAGEOBJ_H_
 #define CORE_INCLUDE_FPDFAPI_FPDF_PAGEOBJ_H_
 
 #include "../fxge/fx_ge.h"
@@ skipping 70 matching lines @@
     void                                Append(CPDF_Path src, const CFX_AffineMatrix* pMatrix)
     {
         m_pObject->Append(src.m_pObject, pMatrix);
     }
 
     void                                AppendRect(FX_FLOAT left, FX_FLOAT bottom, FX_FLOAT right, FX_FLOAT top)
     {
         m_pObject->AppendRect(left, bottom, right, top);
     }
 
-    FX_BOOL                             IsRect() const
+    bool                                IsRect() const
     {
         return m_pObject->IsRect();
     }
 };
 class CPDF_ClipPathData
 {
 public:
 
     CPDF_ClipPathData();
 
@@ skipping 38 matching lines @@
         return m_pObject->m_TextCount;
     }
 
     CPDF_TextObject*    GetText(int i) const
     {
         return m_pObject->m_pTextList[i];
     }
 
     CFX_FloatRect               GetClipBox() const;
 
-    void                                AppendPath(CPDF_Path path, int type, FX_BOOL bAutoMerge);
+    void                                AppendPath(CPDF_Path path, int type, bool bAutoMerge);
 
     void                                DeletePath(int layer_index);
 
     void                                AppendTexts(CPDF_TextObject** pTexts, int count);
 
     void                                Transform(const CFX_AffineMatrix& matrix);
 };
 class CPDF_ColorStateData
 {
 public:
@@ skipping 124 matching lines @@
     FX_FLOAT                    m_FillAlpha;
 
     CPDF_Object*                m_pTR;
 
     CPDF_TransferFunc*  m_pTransferFunc;
 
     CFX_Matrix                  m_Matrix;
 
     int                                 m_RenderIntent;
 
-    FX_BOOL                             m_StrokeAdjust;
+    bool                                m_StrokeAdjust;
 
-    FX_BOOL                             m_AlphaSource;
+    bool                                m_AlphaSource;
 
-    FX_BOOL                             m_TextKnockout;
+    bool                                m_TextKnockout;
 
-    FX_BOOL                             m_StrokeOP;
+    bool                                m_StrokeOP;
 
-    FX_BOOL                             m_FillOP;
+    bool                                m_FillOP;
 
     int                                 m_OPMode;
 
     CPDF_Object*                m_pBG;
 
     CPDF_Object*                m_pUCR;
 
     CPDF_Object*                m_pHT;
 
     FX_FLOAT                    m_Flatness;
 
     FX_FLOAT                    m_Smoothness;
 };
 class CPDF_GeneralState : public CFX_CountRef<CPDF_GeneralStateData>
 {
 public:
 
     void                                SetRenderIntent(const CFX_ByteString& ri);
 
     int                                 GetBlendType() const
     {
         return m_pObject ? m_pObject->m_BlendType : FXDIB_BLEND_NORMAL;
     }
 
-    int                                 GetAlpha(FX_BOOL bStroke) const
+    int                                 GetAlpha(bool bStroke) const
     {
         return m_pObject ? FXSYS_round((bStroke ? m_pObject->m_StrokeAlpha : m_pObject->m_FillAlpha) * 255) : 255;
     }
 };
 class CPDF_ContentMarkItem
 {
 public:
 
     typedef enum {
         None,
@@ skipping 16 matching lines @@
     inline ParamType    GetParamType() const
     {
         return m_ParamType;
     }
 
     inline void*                GetParam() const
     {
         return m_pParam;
     }
 
-    inline FX_BOOL              HasMCID() const;
+    inline bool         HasMCID() const;
 
     inline void                 SetName(const CFX_ByteString& name)
     {
         m_MarkName = name;
     }
 
     inline void                 SetParam(ParamType type, void* param)
     {
         m_ParamType = type;
         m_pParam = param;
@@ skipping 19 matching lines @@
         return m_Marks.GetSize();
     }
 
     inline CPDF_ContentMarkItem&        GetItem(int index) const
     {
         return m_Marks[index];
     }
 
     int                                 GetMCID() const;
 
-    void                                AddMark(const CFX_ByteString& name, CPDF_Dictionary* pDict, FX_BOOL bDictNeedClone);
+    void                                AddMark(const CFX_ByteString& name, CPDF_Dictionary* pDict, bool bDictNeedClone);
 
     void                                DeleteLastMark();
 private:
 
     CFX_ObjectArray<CPDF_ContentMarkItem>       m_Marks;
 };
 class CPDF_ContentMark : public CFX_CountRef<CPDF_ContentMarkData>
 {
 public:
 
     int                                 GetMCID() const
     {
         return m_pObject ? m_pObject->GetMCID() : -1;
     }
 
-    FX_BOOL                             HasMark(const CFX_ByteStringC& mark) const;
+    bool                                HasMark(const CFX_ByteStringC& mark) const;
 
-    FX_BOOL                             LookupMark(const CFX_ByteStringC& mark, CPDF_Dictionary*& pDict) const;
+    bool                                LookupMark(const CFX_ByteStringC& mark, CPDF_Dictionary*& pDict) const;
 };
 
 #define PDFPAGE_TEXT     1
 #define PDFPAGE_PATH     2
 #define PDFPAGE_IMAGE    3
 #define PDFPAGE_SHADING  4
 #define PDFPAGE_FORM     5
 
 class CPDF_GraphicStates
 {
@@ skipping 20 matching lines @@
     virtual ~CPDF_PageObject();
 
     CPDF_PageObject*    Clone() const;
 
     void                                Copy(const CPDF_PageObject* pSrcObject);
 
     virtual void Transform(const CFX_AffineMatrix& matrix) = 0;
 
     void                                RemoveClipPath();
 
-    void                                AppendClipPath(CPDF_Path path, int type, FX_BOOL bAutoMerge);
+    void                                AppendClipPath(CPDF_Path path, int type, bool bAutoMerge);
 
     void                                CopyClipPath(CPDF_PageObject* pObj);
 
     void                                TransformClipPath(CFX_AffineMatrix& matrix);
 
     void                                TransformGeneralState(CFX_AffineMatrix& matrix);
 
     void                                SetColorState(CPDF_ColorState state)
     {
         m_ColorState = state;
@@ skipping 147 matching lines @@
 
     virtual ~CPDF_PathObject() {}
     void Transform(const CFX_AffineMatrix& maxtrix) override;
 
     void                                SetGraphState(CPDF_GraphState GraphState);
 
     CPDF_Path                   m_Path;
 
     int                                 m_FillType;
 
-    FX_BOOL                             m_bStroke;
+    bool                                m_bStroke;
 
     CFX_AffineMatrix    m_Matrix;
 
 
     void                                CalcBoundingBox();
 
 protected:
     void CopyData(const CPDF_PageObject* pSrcObject) override;
 };
 
@@ skipping 51 matching lines @@
 
     CFX_AffineMatrix    m_FormMatrix;
 
     void                                CalcBoundingBox();
 
 protected:
     void CopyData(const CPDF_PageObject* pSrcObject) override;
 };
 
 #endif  // CORE_INCLUDE_FPDFAPI_FPDF_PAGEOBJ_H_