FX_BOOL considered harmful.

fpdfsdk/include/pdfwindow/PWL_Utils.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_INCLUDE_PDFWINDOW_PWL_UTILS_H_
 #define FPDFSDK_INCLUDE_PDFWINDOW_PWL_UTILS_H_
 
 #include "../../../core/include/fpdfapi/fpdf_parser.h"  // For CPDF_Point.
@@ skipping 91 matching lines @@
         PWL_PATHDATA_TYPE                                               type;
 };
 
 class IPWL_SpellCheck;
 
 class PWL_CLASS CPWL_Utils
 {
 public:
         static CPDF_Rect                                                InflateRect(const CPDF_Rect& rcRect, FX_FLOAT fSize);
         static CPDF_Rect                                                DeflateRect(const CPDF_Rect& rcRect, FX_FLOAT fSize);
-        static FX_BOOL                                                  IntersectRect(const CPDF_Rect& rect1, const CPDF_Rect& rect2);
-        static FX_BOOL                                                  ContainsRect(const CPDF_Rect& rcParent, const CPDF_Rect& rcChild);
+        static bool                                                     IntersectRect(const CPDF_Rect& rect1, const CPDF_Rect& rect2);
+        static bool                                                     ContainsRect(const CPDF_Rect& rcParent, const CPDF_Rect& rcChild);
         static CPDF_Rect                                                ScaleRect(const CPDF_Rect& rcRect,FX_FLOAT fScale);
         static CPVT_WordRange                                   OverlapWordRange(const CPVT_WordRange& wr1, const CPVT_WordRange& wr2);
         static CPDF_Rect                                                GetCenterSquare(const CPDF_Rect & rect);
         static CPWL_Color                                               SubstractColor(const CPWL_Color & sColor,FX_FLOAT fColorSub);
         static CPWL_Color                                               DevideColor(const CPWL_Color & sColor,FX_FLOAT fColorDevide);
         static CPDF_Rect                                                MaxRect(const CPDF_Rect & rect1,const CPDF_Rect & rect2);
         static CPDF_Rect                                                OffsetRect(const CPDF_Rect & rect,FX_FLOAT x,FX_FLOAT y);
         static CPDF_Point                                               OffsetPoint(const  CPDF_Point & point,FX_FLOAT x,FX_FLOAT y);
         static FX_COLORREF                                              PWLColorToFXColor(const CPWL_Color& color, int32_t nTransparancy = 255);
-        static FX_BOOL                                                  IsBlackOrWhite(const CPWL_Color& color);
+        static bool                                                     IsBlackOrWhite(const CPWL_Color& color);
         static CPWL_Color                                               GetReverseColor(const CPWL_Color& color);
 
-        static CFX_ByteString                                   GetColorAppStream(const CPWL_Color & color,const FX_BOOL & bFillOrStroke = TRUE);
+        static CFX_ByteString                                   GetColorAppStream(const CPWL_Color & color,const bool & bFillOrStroke = true);
         static CFX_ByteString                                   GetBorderAppStream(const CPDF_Rect & rect, FX_FLOAT fWidth,
                                                                                                 const CPWL_Color & color, const CPWL_Color & crLeftTop, const CPWL_Color & crRightBottom,
                                                                                                 int32_t nStyle, const CPWL_Dash & dash);
         static CFX_ByteString                                   GetCircleBorderAppStream(const CPDF_Rect & rect, FX_FLOAT fWidth,
                                                                                                 const CPWL_Color & color, const CPWL_Color & crLeftTop, const CPWL_Color & crRightBottom,
                                                                                                 int32_t nStyle, const CPWL_Dash & dash);
         static CFX_ByteString                                   GetRectFillAppStream(const CPDF_Rect & rect,const CPWL_Color & color);
         static CFX_ByteString                                   GetCircleFillAppStream(const CPDF_Rect & rect,const CPWL_Color & color);
 
         static CFX_ByteString                                   GetPushButtonAppStream(const CPDF_Rect & rcBBox,
                                                                                                                 IFX_Edit_FontMap * pFontMap,
                                                                                                                 CPDF_Stream * pIconStream,
                                                                                                                 CPDF_IconFit & IconFit,
                                                                                                                 const CFX_WideString & sLabel,
                                                                                                                 const CPWL_Color & crText,
                                                                                                                 FX_FLOAT fFontSize,
                                                                                                                 int32_t nLayOut);
         static CFX_ByteString                                   GetCheckBoxAppStream(const CPDF_Rect & rcBBox,
                                                                                                                 int32_t nStyle,
                                                                                                                 const CPWL_Color & crText);
         static CFX_ByteString                                   GetRadioButtonAppStream(const CPDF_Rect & rcBBox,
                                                                                                                 int32_t nStyle,
                                                                                                                 const CPWL_Color & crText);
 
         static CFX_ByteString                                   GetEditAppStream(IFX_Edit* pEdit, const CPDF_Point & ptOffset, const CPVT_WordRange * pRange = NULL,
-                                                                                                                FX_BOOL bContinuous = TRUE, FX_WORD SubWord = 0);
+                                                                                                                bool bContinuous = true, FX_WORD SubWord = 0);
         static CFX_ByteString                                   GetEditSelAppStream(IFX_Edit* pEdit, const CPDF_Point & ptOffset,
                                                                                                                 const CPVT_WordRange * pRange = NULL);
         static CFX_ByteString                                   GetSpellCheckAppStream(IFX_Edit* pEdit, IPWL_SpellCheck* pSpellCheck,
                                                                                                                 const CPDF_Point & ptOffset,
                                                                                                                 const CPVT_WordRange * pRange = NULL);
         static CFX_ByteString                                   GetTextAppStream(const CPDF_Rect & rcBBox,IFX_Edit_FontMap * pFontMap,
                                                                                                                 const CFX_WideString & sText, int32_t nAlignmentH, int32_t nAlignmentV,
-                                                                                                                FX_FLOAT fFontSize, FX_BOOL bMultiLine, FX_BOOL bAutoReturn, const CPWL_Color & crText);
+                                                                                                                FX_FLOAT fFontSize, bool bMultiLine, bool bAutoReturn, const CPWL_Color & crText);
         static CFX_ByteString                                   GetDropButtonAppStream(const CPDF_Rect & rcBBox);
 
         static void                                                             DrawFillRect(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,const CPDF_Rect & rect,
                                                                                                                 const CPWL_Color & color, int32_t nTransparancy);
         static void                                                             DrawFillRect(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,
                                                                                                                 const CPDF_Rect & rect,const FX_COLORREF & color);
         static void                                                             DrawStrokeRect(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,const CPDF_Rect & rect,
                                                                                                                 const FX_COLORREF & color, FX_FLOAT fWidth);
         static void                                                             DrawStrokeLine(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,
                                                                                                                 const CPDF_Point & ptMoveTo, const CPDF_Point & ptLineTo, const FX_COLORREF & color, FX_FLOAT fWidth);
         static void                                                             DrawBorder(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,
                                                                                                 const CPDF_Rect & rect, FX_FLOAT fWidth,
                                                                                                 const CPWL_Color & color, const CPWL_Color & crLeftTop, const CPWL_Color & crRightBottom,
                                                                                                 int32_t nStyle, const CPWL_Dash & dash, int32_t nTransparancy);
         static void                                                             DrawFillArea(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,
                                                                                                                 const CPDF_Point* pPts, int32_t nCount, const FX_COLORREF& color);
         static void                                                             DrawShadow(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device,
-                                                                                                                FX_BOOL bVertical, FX_BOOL bHorizontal, CPDF_Rect rect,
+                                                                                                                bool bVertical, bool bHorizontal, CPDF_Rect rect,
                                                                                                                 int32_t nTransparancy, int32_t nStartGray, int32_t nEndGray);
         static void                                                             DrawEditSpellCheck(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device, IFX_Edit* pEdit,
                                                                                                                 const CPDF_Rect& rcClip, const CPDF_Point& ptOffset, const CPVT_WordRange* pRange,
                                                                                                                 IPWL_SpellCheck* pSpellCheck);
 public:
         static void                                                             ConvertCMYK2RGB(FX_FLOAT dC,FX_FLOAT dM,FX_FLOAT dY,FX_FLOAT dK,FX_FLOAT &dR,FX_FLOAT &dG,FX_FLOAT &dB);
         static void                                                             ConvertRGB2CMYK(FX_FLOAT dR,FX_FLOAT dG,FX_FLOAT dB,FX_FLOAT &dC,FX_FLOAT &dM,FX_FLOAT &dY,FX_FLOAT &dK);
 
         static void                                                             ConvertRGB2GRAY(FX_FLOAT dR,FX_FLOAT dG,FX_FLOAT dB,FX_FLOAT &dGray);
         static void                                                             ConvertGRAY2RGB(FX_FLOAT dGray,FX_FLOAT &dR,FX_FLOAT &dG,FX_FLOAT &dB);
@@ skipping 45 matching lines @@
         static void                                                             GetGraphics_UpArrow(CFX_ByteString& sPathData, CFX_PathData& path, const CPDF_Rect& crBBox, const PWL_PATH_TYPE type);
         static void                                                             GetGraphics_UpLeftArrow(CFX_ByteString& sPathData, CFX_PathData& path, const CPDF_Rect& crBBox, const PWL_PATH_TYPE type);
         static void                                                             GetGraphics_Graph(CFX_ByteString& sPathData, CFX_PathData& path, const CPDF_Rect& crBBox, const PWL_PATH_TYPE type);
         static void                                                             GetGraphics_Paperclip(CFX_ByteString& sPathData, CFX_PathData& path, const CPDF_Rect& crBBox, const PWL_PATH_TYPE type);
         static void                                                             GetGraphics_Attachment(CFX_ByteString& sPathData, CFX_PathData& path, const CPDF_Rect& crBBox, const PWL_PATH_TYPE type);
         static void                                                             GetGraphics_Tag(CFX_ByteString& sPathData, CFX_PathData& path, const CPDF_Rect& crBBox, const PWL_PATH_TYPE type);
         static void                                                             GetGraphics_Foxit(CFX_ByteString& sPathData, CFX_PathData& path, const CPDF_Rect& crBBox, const PWL_PATH_TYPE type);
 };
 
 #endif  // FPDFSDK_INCLUDE_PDFWINDOW_PWL_UTILS_H_