FX_BOOL considered harmful.

fpdfsdk/src/pdfwindow/PWL_Caret.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/pdfwindow/PDFWindow.h"
 #include "../../include/pdfwindow/PWL_Wnd.h"
 #include "../../include/pdfwindow/PWL_Caret.h"
 #include "../../include/pdfwindow/PWL_Utils.h"
 
 #define PWL_CARET_FLASHINTERVAL         500
 
 //////////////////////////////////////////////////////////////////////
 // Construction/Destruction
 //////////////////////////////////////////////////////////////////////
 
 CPWL_Caret::CPWL_Caret() :
-        m_bFlash(FALSE),
+        m_bFlash(false),
         m_ptHead(0,0),
         m_ptFoot(0,0),
         m_fWidth(0.4f),
         m_nDelay(0)
 {
 }
 
 CPWL_Caret::~CPWL_Caret()
 {
 }
@@ skipping 98 matching lines @@
 }
 
 CPDF_Rect CPWL_Caret::GetCaretRect() const
 {
         return CPDF_Rect(m_ptFoot.x,
                         m_ptFoot.y,
                         m_ptHead.x + m_fWidth,
                         m_ptHead.y);
 }
 
-void CPWL_Caret::SetCaret(FX_BOOL bVisible, const CPDF_Point & ptHead, const CPDF_Point & ptFoot)
+void CPWL_Caret::SetCaret(bool bVisible, const CPDF_Point & ptHead, const CPDF_Point & ptFoot)
 {
         if (bVisible)
         {
                 if (IsVisible())
                 {
                         if (m_ptHead.x != ptHead.x || m_ptHead.y != ptHead.y ||
                                         m_ptFoot.x != ptFoot.x || m_ptFoot.y != ptFoot.y)
                         {
                                 m_ptHead = ptHead;
                                 m_ptFoot = ptFoot;
 
-                                m_bFlash = TRUE;
-                                //Move(GetCaretRect(),FALSE,TRUE);
-                                Move(m_rcInvalid, FALSE, TRUE);
+                                m_bFlash = true;
+                                //Move(GetCaretRect(),false,true);
+                                Move(m_rcInvalid, false, true);
                         }
                 }
                 else
                 {
                         m_ptHead = ptHead;
                         m_ptFoot = ptFoot;
 
                         EndTimer();
                         BeginTimer(PWL_CARET_FLASHINTERVAL);
 
-                        CPWL_Wnd::SetVisible(TRUE);
-                        m_bFlash = TRUE;
+                        CPWL_Wnd::SetVisible(true);
+                        m_bFlash = true;
 
-                        //Move(GetCaretRect(),FALSE,TRUE);
-                        Move(m_rcInvalid, FALSE, TRUE);
+                        //Move(GetCaretRect(),false,true);
+                        Move(m_rcInvalid, false, true);
                 }
         }
         else
         {
                 m_ptHead = CPDF_Point(0, 0);
                 m_ptFoot = CPDF_Point(0, 0);
 
-                m_bFlash = FALSE;
+                m_bFlash = false;
                 if (IsVisible())
                 {
                         EndTimer();
-                        CPWL_Wnd::SetVisible(FALSE);
+                        CPWL_Wnd::SetVisible(false);
                 }
         }
 }
 
 void CPWL_Caret::InvalidateRect(CPDF_Rect * pRect)
 {
         if (pRect)
         {
                 CPDF_Rect rcRefresh = CPWL_Utils::InflateRect(*pRect,0.5f);
                 rcRefresh.top += 1;
                 rcRefresh.bottom -= 1;
 
                 CPWL_Wnd::InvalidateRect(&rcRefresh);
         }
         else
                 CPWL_Wnd::InvalidateRect(pRect);
 }