fpdfsdk/include/formfiller/FFL_ComboBox.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/formfiller/FFL_ComboBox.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/formfiller/FFL_ComboBox.h

diff --git a/fpdfsdk/include/formfiller/FFL_ComboBox.h b/fpdfsdk/include/formfiller/FFL_ComboBox.h

index e5c65c2715a790ead33131c32350fb238960aab6..957fda425fe0d453380a0c6eeeab29cb9fd71dd2 100644

--- a/fpdfsdk/include/formfiller/FFL_ComboBox.h

+++ b/fpdfsdk/include/formfiller/FFL_ComboBox.h

@@ -31,19 +31,19 @@ public:

virtual CPWL_Wnd* NewPDFWindow(const PWL_CREATEPARAM& cp, CPDFSDK_PageView* pPageView);

- virtual FX_BOOL OnChar(CPDFSDK_Annot* pAnnot, FX_UINT nChar, FX_UINT nFlags);

+ virtual bool OnChar(CPDFSDK_Annot* pAnnot, FX_UINT nChar, FX_UINT nFlags);

- virtual FX_BOOL IsDataChanged(CPDFSDK_PageView* pPageView);

+ virtual bool IsDataChanged(CPDFSDK_PageView* pPageView);

virtual void SaveData(CPDFSDK_PageView* pPageView);

virtual void GetActionData(CPDFSDK_PageView* pPageView, CPDF_AAction::AActionType type, PDFSDK_FieldAction& fa);

virtual void SetActionData(CPDFSDK_PageView* pPageView, CPDF_AAction::AActionType type, const PDFSDK_FieldAction& fa);

- virtual FX_BOOL IsActionDataChanged(CPDF_AAction::AActionType type, const PDFSDK_FieldAction& faOld, const PDFSDK_FieldAction& faNew);

+ virtual bool IsActionDataChanged(CPDF_AAction::AActionType type, const PDFSDK_FieldAction& faOld, const PDFSDK_FieldAction& faNew);

virtual void SaveState(CPDFSDK_PageView* pPageView);

virtual void RestoreState(CPDFSDK_PageView* pPageView);

- virtual CPWL_Wnd* ResetPDFWindow(CPDFSDK_PageView* pPageView, FX_BOOL bRestoreValue);

- virtual void OnKeyStroke(FX_BOOL bKeyDown, FX_UINT nFlag);

+ virtual CPWL_Wnd* ResetPDFWindow(CPDFSDK_PageView* pPageView, bool bRestoreValue);

+ virtual void OnKeyStroke(bool bKeyDown, FX_UINT nFlag);

public:

virtual void OnSetFocus(CPWL_Wnd* pWnd);

@@ -53,9 +53,9 @@ public:

virtual void OnAddUndo(CPWL_Edit* pEdit);

public:

- virtual FX_BOOL CanCopy(CPDFSDK_Document* pDocument);

- virtual FX_BOOL CanCut(CPDFSDK_Document* pDocument);

- virtual FX_BOOL CanPaste(CPDFSDK_Document* pDocument);

+ virtual bool CanCopy(CPDFSDK_Document* pDocument);

+ virtual bool CanCut(CPDFSDK_Document* pDocument);

+ virtual bool CanPaste(CPDFSDK_Document* pDocument);

private:

CFX_WideString GetSelectExportText();