FX_BOOL considered harmful.

core/src/fxge/ge/fx_ge_ps.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_ge.h"
 #include "../../../include/fxcodec/fx_codec.h"
 #include "text_int.h"
 struct PSGlyph {
     CFX_Font*           m_pFont;
     FX_DWORD            m_GlyphIndex;
-    FX_BOOL                     m_bGlyphAdjust;
+    bool                        m_bGlyphAdjust;
     FX_FLOAT            m_AdjustMatrix[4];
 };
 class CPSFont
 {
 public:
     PSGlyph                     m_Glyphs[256];
     int                         m_nGlyphs;
 };
 CFX_PSRenderer::CFX_PSRenderer()
 {
     m_pOutput = NULL;
-    m_bColorSet = m_bGraphStateSet = FALSE;
-    m_bInited = FALSE;
+    m_bColorSet = m_bGraphStateSet = false;
+    m_bInited = false;
 }
 CFX_PSRenderer::~CFX_PSRenderer()
 {
     for (int i = 0; i < (int)m_PSFontList.GetSize(); i ++) {
         CPSFont* pFont = m_PSFontList[i];
         delete pFont;
     }
 }
 #define OUTPUT_PS(str) m_pOutput->OutputPS(str, sizeof str-1)
-void CFX_PSRenderer::Init(IFX_PSOutput* pOutput, int pslevel, int width, int height, FX_BOOL bCmykOutput)
+void CFX_PSRenderer::Init(IFX_PSOutput* pOutput, int pslevel, int width, int height, bool bCmykOutput)
 {
     m_PSLevel = pslevel;
     m_pOutput = pOutput;
     m_ClipBox.left = m_ClipBox.top = 0;
     m_ClipBox.right = width;
     m_ClipBox.bottom = height;
     m_bCmykOutput = bCmykOutput;
 }
-FX_BOOL CFX_PSRenderer::StartRendering()
+bool CFX_PSRenderer::StartRendering()
 {
     if (m_bInited) {
-        return TRUE;
+        return true;
     }
     static const char init_str[] = "\nsave\n/im/initmatrix load def\n"
                                    "/n/newpath load def/m/moveto load def/l/lineto load def/c/curveto load def/h/closepath load def\n"
                                    "/f/fill load def/F/eofill load def/s/stroke load def/W/clip load def/W*/eoclip load def\n"
                                    "/rg/setrgbcolor load def/k/setcmykcolor load def\n"
                                    "/J/setlinecap load def/j/setlinejoin load def/w/setlinewidth load def/M/setmiterlimit load def/d/setdash load def\n"
                                    "/q/gsave load def/Q/grestore load def/iM/imagemask load def\n"
                                    "/Tj/show load def/Ff/findfont load def/Fs/scalefont load def/Sf/setfont load def\n"
                                    "/cm/concat load def/Cm/currentmatrix load def/mx/matrix load def/sm/setmatrix load def\n"
                                    ;
     OUTPUT_PS(init_str);
-    m_bInited = TRUE;
-    return TRUE;
+    m_bInited = true;
+    return true;
 }
 void CFX_PSRenderer::EndRendering()
 {
     if (m_bInited) {
         OUTPUT_PS("\nrestore\n");
     }
-    m_bInited = FALSE;
+    m_bInited = false;
 }
 void CFX_PSRenderer::SaveState()
 {
     StartRendering();
     OUTPUT_PS("q\n");
     m_ClipBoxStack.Add(m_ClipBox);
 }
-void CFX_PSRenderer::RestoreState(FX_BOOL bKeepSaved)
+void CFX_PSRenderer::RestoreState(bool bKeepSaved)
 {
     StartRendering();
     if (bKeepSaved) {
         OUTPUT_PS("Q\nq\n");
     } else {
         OUTPUT_PS("Q\n");
     }
-    m_bColorSet = m_bGraphStateSet = FALSE;
+    m_bColorSet = m_bGraphStateSet = false;
     m_ClipBox = m_ClipBoxStack.GetAt(m_ClipBoxStack.GetSize() - 1);
     if (!bKeepSaved) {
         m_ClipBoxStack.RemoveAt(m_ClipBoxStack.GetSize() - 1);
     }
 }
 void CFX_PSRenderer::OutputPath(const CFX_PathData* pPathData, const CFX_AffineMatrix* pObject2Device)
 {
     int nPoints = pPathData->GetPointCount();
     CFX_ByteTextBuf buf;
     buf.EstimateSize(nPoints * 10);
@@ skipping 73 matching lines @@
     OutputPath(pPathData, NULL);
     CFX_FloatRect rect = pPathData->GetBoundingBox(pGraphState->m_LineWidth, pGraphState->m_MiterLimit);
     rect.Transform(pObject2Device);
     m_ClipBox.Intersect(rect.GetOutterRect());
     if (pObject2Device) {
         OUTPUT_PS("strokepath W n sm\n");
     } else {
         OUTPUT_PS("strokepath W n\n");
     }
 }
-FX_BOOL CFX_PSRenderer::DrawPath(const CFX_PathData* pPathData,
+bool CFX_PSRenderer::DrawPath(const CFX_PathData* pPathData,
                                  const CFX_AffineMatrix* pObject2Device,
                                  const CFX_GraphStateData* pGraphState,
                                  FX_DWORD fill_color,
                                  FX_DWORD stroke_color,
                                  int fill_mode,
                                  int alpha_flag,
                                  void* pIccTransform
                                 )
 {
     StartRendering();
     int fill_alpha = FXGETFLAG_COLORTYPE(alpha_flag) ? FXGETFLAG_ALPHA_FILL(alpha_flag) : FXARGB_A(fill_color);
     int stroke_alpha = FXGETFLAG_COLORTYPE(alpha_flag) ? FXGETFLAG_ALPHA_STROKE(alpha_flag) : FXARGB_A(stroke_color);
     if (fill_alpha && fill_alpha < 255) {
-        return FALSE;
+        return false;
     }
     if (stroke_alpha && stroke_alpha < 255) {
-        return FALSE;
+        return false;
     }
     if (fill_alpha == 0 && stroke_alpha == 0) {
-        return FALSE;
+        return false;
     }
     if (stroke_alpha) {
         SetGraphState(pGraphState);
         if (pObject2Device) {
             CFX_ByteTextBuf buf;
             buf << FX_BSTRC("mx Cm [") << pObject2Device->a << FX_BSTRC(" ") << pObject2Device->b << FX_BSTRC(" ") <<
                 pObject2Device->c << FX_BSTRC(" ") << pObject2Device->d << FX_BSTRC(" ") << pObject2Device->e <<
                 FX_BSTRC(" ") << pObject2Device->f << FX_BSTRC("]cm ");
             m_pOutput->OutputPS((const FX_CHAR*)buf.GetBuffer(), buf.GetSize());
         }
@@ skipping 17 matching lines @@
     }
     if (stroke_alpha) {
         SetColor(stroke_color, alpha_flag, pIccTransform);
         if (pObject2Device) {
             OUTPUT_PS("s sm");
         } else {
             OUTPUT_PS("s");
         }
     }
     OUTPUT_PS("\n");
-    return TRUE;
+    return true;
 }
 void CFX_PSRenderer::SetGraphState(const CFX_GraphStateData* pGraphState)
 {
     CFX_ByteTextBuf buf;
     if (!m_bGraphStateSet || m_CurGraphState.m_LineCap != pGraphState->m_LineCap) {
         buf << pGraphState->m_LineCap << FX_BSTRC(" J\n");
     }
     if (!m_bGraphStateSet || m_CurGraphState.m_DashCount != pGraphState->m_DashCount ||
             FXSYS_memcmp(m_CurGraphState.m_DashArray, pGraphState->m_DashArray, sizeof(FX_FLOAT)*m_CurGraphState.m_DashCount)) {
         buf << FX_BSTRC("[");
         for (int i = 0; i < pGraphState->m_DashCount; i ++) {
             buf << pGraphState->m_DashArray[i] << FX_BSTRC(" ");
         }
         buf << FX_BSTRC("]") << pGraphState->m_DashPhase << FX_BSTRC(" d\n");
     }
     if (!m_bGraphStateSet || m_CurGraphState.m_LineJoin != pGraphState->m_LineJoin) {
         buf << pGraphState->m_LineJoin << FX_BSTRC(" j\n");
     }
     if (!m_bGraphStateSet || m_CurGraphState.m_LineWidth != pGraphState->m_LineWidth) {
         buf << pGraphState->m_LineWidth << FX_BSTRC(" w\n");
     }
     if (!m_bGraphStateSet || m_CurGraphState.m_MiterLimit != pGraphState->m_MiterLimit) {
         buf << pGraphState->m_MiterLimit << FX_BSTRC(" M\n");
     }
     m_CurGraphState.Copy(*pGraphState);
-    m_bGraphStateSet = TRUE;
+    m_bGraphStateSet = true;
     if (buf.GetSize()) {
         m_pOutput->OutputPS((const FX_CHAR*)buf.GetBuffer(), buf.GetSize());
     }
 }
 static void FaxCompressData(uint8_t* src_buf, int width, int height, uint8_t*& dest_buf, FX_DWORD& dest_size)
 {
     CCodec_ModuleMgr* pEncoders = CFX_GEModule::Get()->GetCodecModule();
     if (width * height > 128 && pEncoders && pEncoders->GetFaxModule()->Encode(src_buf, width, height, (width + 7) / 8, dest_buf, dest_size)) {
         FX_Free(src_buf);
     } else {
@@ skipping 25 matching lines @@
     if (dest_size < src_size) {
         output_buf = dest_buf;
         output_size = dest_size;
     } else {
         filter = NULL;
         if (dest_buf) {
             FX_Free(dest_buf);
         }
     }
 }
-FX_BOOL CFX_PSRenderer::SetDIBits(const CFX_DIBSource* pSource, FX_DWORD color, int left, int top,
+bool CFX_PSRenderer::SetDIBits(const CFX_DIBSource* pSource, FX_DWORD color, int left, int top,
                                   int alpha_flag, void* pIccTransform)
 {
     StartRendering();
     CFX_AffineMatrix matrix((FX_FLOAT)(pSource->GetWidth()), 0.0f, 0.0f, -(FX_FLOAT)(pSource->GetHeight()),
                             (FX_FLOAT)(left), (FX_FLOAT)(top + pSource->GetHeight()));
     return DrawDIBits(pSource, color, &matrix, 0, alpha_flag, pIccTransform);
 }
-FX_BOOL CFX_PSRenderer::StretchDIBits(const CFX_DIBSource* pSource, FX_DWORD color, int dest_left, int dest_top,
+bool CFX_PSRenderer::StretchDIBits(const CFX_DIBSource* pSource, FX_DWORD color, int dest_left, int dest_top,
                                       int dest_width, int dest_height, FX_DWORD flags,
                                       int alpha_flag, void* pIccTransform)
 {
     StartRendering();
     CFX_AffineMatrix matrix((FX_FLOAT)(dest_width), 0.0f, 0.0f, (FX_FLOAT)(-dest_height),
                             (FX_FLOAT)(dest_left), (FX_FLOAT)(dest_top + dest_height));
     return DrawDIBits(pSource, color, &matrix, flags, alpha_flag, pIccTransform);
 }
-FX_BOOL CFX_PSRenderer::DrawDIBits(const CFX_DIBSource* pSource, FX_DWORD color,
+bool CFX_PSRenderer::DrawDIBits(const CFX_DIBSource* pSource, FX_DWORD color,
                                    const CFX_AffineMatrix* pMatrix, FX_DWORD flags,
                                    int alpha_flag, void* pIccTransform)
 {
     StartRendering();
     if ((pMatrix->a == 0 && pMatrix->b == 0) || (pMatrix->c == 0 && pMatrix->d == 0)) {
-        return TRUE;
+        return true;
     }
     if (pSource->HasAlpha()) {
-        return FALSE;
+        return false;
     }
     int alpha = FXGETFLAG_COLORTYPE(alpha_flag) ? FXGETFLAG_ALPHA_FILL(color) : FXARGB_A(color);
     if (pSource->IsAlphaMask() && (alpha < 255 || pSource->GetBPP() != 1)) {
-        return FALSE;
+        return false;
     }
     OUTPUT_PS("q\n");
     CFX_ByteTextBuf buf;
     buf << FX_BSTRC("[") << pMatrix->a << FX_BSTRC(" ") << pMatrix->b << FX_BSTRC(" ") <<
         pMatrix->c << FX_BSTRC(" ") << pMatrix->d << FX_BSTRC(" ") << pMatrix->e <<
         FX_BSTRC(" ") << pMatrix->f << FX_BSTRC("]cm ");
     int width = pSource->GetWidth();
     int height = pSource->GetHeight();
     buf << width << FX_BSTRC(" ") << height;
     if (pSource->GetBPP() == 1 && pSource->GetPalette() == NULL) {
         int pitch = (width + 7) / 8;
         FX_DWORD src_size = height * pitch;
         uint8_t* src_buf = FX_Alloc(uint8_t, src_size);
         for (int row = 0; row < height; row ++) {
             const uint8_t* src_scan = pSource->GetScanline(row);
             FXSYS_memcpy(src_buf + row * pitch, src_scan, pitch);
         }
         uint8_t* output_buf;
         FX_DWORD output_size;
         FaxCompressData(src_buf, width, height, output_buf, output_size);
         if (pSource->IsAlphaMask()) {
             SetColor(color, alpha_flag, pIccTransform);
-            m_bColorSet = FALSE;
+            m_bColorSet = false;
             buf << FX_BSTRC(" true[");
         } else {
             buf << FX_BSTRC(" 1[");
         }
         buf << width << FX_BSTRC(" 0 0 -") << height << FX_BSTRC(" 0 ") << height <<
             FX_BSTRC("]currentfile/ASCII85Decode filter ");
         if (output_buf != src_buf)
             buf << FX_BSTRC("<</K -1/EndOfBlock false/Columns ") << width << FX_BSTRC("/Rows ") << height <<
                 FX_BSTRC(">>/CCITTFaxDecode filter ");
         if (pSource->IsAlphaMask()) {
@@ skipping 27 matching lines @@
                     if (pSource->GetPalette() != NULL) {
                         pConverted = pSource->CloneConvert(FXDIB_Cmyk);
                     }
                     break;
                 default:
                     break;
             }
         }
         if (pConverted == NULL) {
             OUTPUT_PS("\nQ\n");
-            return FALSE;
+            return false;
         }
         int Bpp = pConverted->GetBPP() / 8;
         uint8_t* output_buf = NULL;
         FX_STRSIZE output_size = 0;
         const FX_CHAR* filter = NULL;
         if (flags & FXRENDER_IMAGE_LOSSY) {
             CCodec_ModuleMgr* pEncoders = CFX_GEModule::Get()->GetCodecModule();
             if (pEncoders && pEncoders->GetJpegModule()->Encode(pConverted, output_buf, output_size)) {
                 filter = "/DCTDecode filter ";
             }
@@ skipping 35 matching lines @@
         if (filter) {
             buf << filter;
         }
         buf << FX_BSTRC("false ") << Bpp;
         buf << FX_BSTRC(" colorimage\n");
         m_pOutput->OutputPS((const FX_CHAR*)buf.GetBuffer(), buf.GetSize());
         WritePSBinary(output_buf, output_size);
         FX_Free(output_buf);
     }
     OUTPUT_PS("\nQ\n");
-    return TRUE;
+    return true;
 }
 void CFX_PSRenderer::SetColor(FX_DWORD color, int alpha_flag, void* pIccTransform)
 {
     if (!CFX_GEModule::Get()->GetCodecModule() || !CFX_GEModule::Get()->GetCodecModule()->GetIccModule()) {
         pIccTransform = NULL;
     }
-    FX_BOOL bCMYK = FALSE;
+    bool bCMYK = false;
     if (pIccTransform) {
         ICodec_IccModule* pIccModule = CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
         color = FXGETFLAG_COLORTYPE(alpha_flag) ? FXCMYK_TODIB(color) : FXARGB_TODIB(color);
         uint8_t* pColor = (uint8_t*)&color;
         pIccModule->TranslateScanline(pIccTransform, pColor, pColor, 1);
         color = m_bCmykOutput ? FXCMYK_TODIB(color) : FXARGB_TODIB(color);
         bCMYK = m_bCmykOutput;
     } else {
         bCMYK = FXGETFLAG_COLORTYPE(alpha_flag);
     }
     if (bCMYK != m_bCmykOutput || !m_bColorSet || m_LastColor != color) {
         CFX_ByteTextBuf buf;
         if (bCMYK) {
             buf << FXSYS_GetCValue(color) / 255.0 << FX_BSTRC(" ") << FXSYS_GetMValue(color) / 255.0 << FX_BSTRC(" ")
                 << FXSYS_GetYValue(color) / 255.0 << FX_BSTRC(" ") << FXSYS_GetKValue(color) / 255.0 << FX_BSTRC(" k\n");
         } else {
             buf << FXARGB_R(color) / 255.0 << FX_BSTRC(" ") << FXARGB_G(color) / 255.0 << FX_BSTRC(" ")
                 << FXARGB_B(color) / 255.0 << FX_BSTRC(" rg\n");
         }
         if (bCMYK == m_bCmykOutput) {
-            m_bColorSet = TRUE;
+            m_bColorSet = true;
             m_LastColor = color;
         }
         m_pOutput->OutputPS((const FX_CHAR*)buf.GetBuffer(), buf.GetSize());
     }
 }
 void CFX_PSRenderer::FindPSFontGlyph(CFX_FaceCache* pFaceCache, CFX_Font* pFont, const FXTEXT_CHARPOS& charpos,
                                      int& ps_fontnum, int &ps_glyphindex)
 {
     for (int i = 0; i < (int)m_PSFontList.GetSize(); i ++) {
         CPSFont* pPSFont = m_PSFontList[i];
@@ skipping 77 matching lines @@
                     break;
                 }
         }
     }
     buf << FX_BSTRC("f");
     buf << FX_BSTRC("}bind def end\n");
     buf << FX_BSTRC("/X") << ps_fontnum << FX_BSTRC(" Ff/Encoding get ") << ps_glyphindex
         << FX_BSTRC("/") << ps_glyphindex << FX_BSTRC(" put\n");
     m_pOutput->OutputPS((const FX_CHAR*)buf.GetBuffer(), buf.GetSize());
 }
-FX_BOOL CFX_PSRenderer::DrawText(int nChars, const FXTEXT_CHARPOS* pCharPos, CFX_Font* pFont,
+bool CFX_PSRenderer::DrawText(int nChars, const FXTEXT_CHARPOS* pCharPos, CFX_Font* pFont,
                                  CFX_FontCache* pCache, const CFX_AffineMatrix* pObject2Device,
                                  FX_FLOAT font_size, FX_DWORD color,
                                  int alpha_flag, void* pIccTransform)
 {
     StartRendering();
     int alpha = FXGETFLAG_COLORTYPE(alpha_flag) ? FXGETFLAG_ALPHA_FILL(alpha_flag) : FXARGB_A(color);
     if (alpha < 255) {
-        return FALSE;
+        return false;
     }
     if ((pObject2Device->a == 0 && pObject2Device->b == 0) || (pObject2Device->c == 0 && pObject2Device->d == 0)) {
-        return TRUE;
+        return true;
     }
     SetColor(color, alpha_flag, pIccTransform);
     CFX_ByteTextBuf buf;
     buf << FX_BSTRC("q[") << pObject2Device->a << FX_BSTRC(" ") << pObject2Device->b << FX_BSTRC(" ")
         << pObject2Device->c << FX_BSTRC(" ") << pObject2Device->d;
     buf << FX_BSTRC(" ") << pObject2Device->e << FX_BSTRC(" ") << pObject2Device->f << "]cm\n";
     if (pCache == NULL) {
         pCache = CFX_GEModule::Get()->GetFontCache();
     }
     CFX_FaceCache* pFaceCache = pCache->GetCachedFace(pFont);
     FX_FONTCACHE_DEFINE(pCache, pFont);
     int last_fontnum = -1;
     for (int i = 0; i < nChars; i ++) {
         int ps_fontnum, ps_glyphindex;
         FindPSFontGlyph(pFaceCache, pFont, pCharPos[i], ps_fontnum, ps_glyphindex);
         if (last_fontnum != ps_fontnum) {
             buf << FX_BSTRC("/X") << ps_fontnum << FX_BSTRC(" Ff ") << font_size
                 << FX_BSTRC(" Fs Sf ");
             last_fontnum = ps_fontnum;
         }
         buf << pCharPos[i].m_OriginX << FX_BSTRC(" ")
             << pCharPos[i].m_OriginY << FX_BSTRC(" m");
         CFX_ByteString hex;
         hex.Format("<%02X>", ps_glyphindex);
         buf << hex << FX_BSTRC("Tj\n");
     }
     buf << FX_BSTRC("Q\n");
     m_pOutput->OutputPS((const FX_CHAR*)buf.GetBuffer(), buf.GetSize());
-    return TRUE;
+    return true;
 }
 void CFX_PSRenderer::WritePSBinary(const uint8_t* data, int len)
 {
     uint8_t* dest_buf;
     FX_DWORD dest_size;
     CCodec_ModuleMgr* pEncoders = CFX_GEModule::Get()->GetCodecModule();
     if (pEncoders && pEncoders->GetBasicModule()->A85Encode(data, len, dest_buf, dest_size)) {
         m_pOutput->OutputPS((const FX_CHAR*)dest_buf, dest_size);
         FX_Free(dest_buf);
     } else {
         m_pOutput->OutputPS((const FX_CHAR*)data, len);
     }
 }