FX_BOOL considered harmful.

core/src/fxge/ge/fx_ge_font.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_ge.h"
 #include "../../../include/fxge/fx_freetype.h"
 #include "text_int.h"
 #define EM_ADJUST(em, a) (em == 0?(a): (a)*1000/em)
 extern void _FPDFAPI_GetInternalFontData(int id1, const uint8_t*& data, FX_DWORD& size);
 CFX_Font::CFX_Font()
 {
     m_pSubstFont = NULL;
     m_Face = NULL;
-    m_bEmbedded = FALSE;
-    m_bVertical = FALSE;
+    m_bEmbedded = false;
+    m_bVertical = false;
     m_pFontData = NULL;
     m_pFontDataAllocation = NULL;
     m_dwSize = 0;
     m_pOwnedStream = NULL;
     m_pGsubData = NULL;
     m_pPlatformFont = NULL;
     m_pPlatformFontCollection = NULL;
     m_pDwFont = NULL;
     m_hHandle = NULL;
-    m_bDwLoaded = FALSE;
+    m_bDwLoaded = false;
 }
 CFX_Font::~CFX_Font()
 {
     delete m_pSubstFont;
     m_pSubstFont = NULL;
     if (m_pFontDataAllocation) {
         FX_Free(m_pFontDataAllocation);
         m_pFontDataAllocation = NULL;
     }
     if (m_Face) {
@@ skipping 16 matching lines @@
     }
 #if _FXM_PLATFORM_  == _FXM_PLATFORM_APPLE_
     ReleasePlatformResource();
 #endif
 }
 void CFX_Font::DeleteFace()
 {
     FXFT_Done_Face(m_Face);
     m_Face = NULL;
 }
-FX_BOOL CFX_Font::LoadSubst(const CFX_ByteString& face_name, FX_BOOL bTrueType, FX_DWORD flags,
-                            int weight, int italic_angle, int CharsetCP, FX_BOOL bVertical)
+bool CFX_Font::LoadSubst(const CFX_ByteString& face_name, bool bTrueType, FX_DWORD flags,
+                            int weight, int italic_angle, int CharsetCP, bool bVertical)
 {
-    m_bEmbedded = FALSE;
+    m_bEmbedded = false;
     m_bVertical = bVertical;
     m_pSubstFont = new CFX_SubstFont;
     m_Face = CFX_GEModule::Get()->GetFontMgr()->FindSubstFont(face_name, bTrueType, flags, weight, italic_angle,
              CharsetCP, m_pSubstFont);
 #if _FXM_PLATFORM_  == _FXM_PLATFORM_APPLE_
     if(m_pSubstFont->m_ExtHandle) {
         m_pPlatformFont = m_pSubstFont->m_ExtHandle;
         m_pSubstFont->m_ExtHandle = NULL;
     }
 #endif
     if (m_Face) {
         m_pFontData = FXFT_Get_Face_Stream_Base(m_Face);
         m_dwSize = FXFT_Get_Face_Stream_Size(m_Face);
     }
-    return TRUE;
+    return true;
 }
 extern "C" {
     unsigned long _FTStreamRead(FXFT_Stream stream, unsigned long offset,
                                 unsigned char* buffer, unsigned long count)
     {
         if (count == 0) {
             return 0;
         }
         IFX_FileRead* pFile = (IFX_FileRead*)stream->descriptor.pointer;
         int res = pFile->ReadBlock(buffer, offset, count);
         if (res) {
             return count;
         }
         return 0;
     }
     void _FTStreamClose(FXFT_Stream stream)
     {
     }
 };
-FX_BOOL _LoadFile(FXFT_Library library, FXFT_Face* Face, IFX_FileRead* pFile, FXFT_Stream* stream)
+bool _LoadFile(FXFT_Library library, FXFT_Face* Face, IFX_FileRead* pFile, FXFT_Stream* stream)
 {
     FXFT_Stream stream1 = (FXFT_Stream)FX_Alloc(uint8_t, sizeof (FXFT_StreamRec));
     stream1->base = NULL;
     stream1->size = (unsigned long)pFile->GetSize();
     stream1->pos = 0;
     stream1->descriptor.pointer = pFile;
     stream1->close = _FTStreamClose;
     stream1->read = _FTStreamRead;
     FXFT_Open_Args args;
     args.flags = FT_OPEN_STREAM;
     args.stream = stream1;
     if (FXFT_Open_Face(library, &args, 0, Face)) {
         FX_Free(stream1);
-        return FALSE;
+        return false;
     }
     if (stream) {
         *stream = stream1;
     }
-    return TRUE;
+    return true;
 }
-FX_BOOL CFX_Font::LoadFile(IFX_FileRead* pFile)
+bool CFX_Font::LoadFile(IFX_FileRead* pFile)
 {
-    m_bEmbedded = FALSE;
+    m_bEmbedded = false;
     FXFT_Library library;
     if (CFX_GEModule::Get()->GetFontMgr()->m_FTLibrary == NULL) {
         FXFT_Init_FreeType(&CFX_GEModule::Get()->GetFontMgr()->m_FTLibrary);
     }
     library = CFX_GEModule::Get()->GetFontMgr()->m_FTLibrary;
     FXFT_Stream stream = NULL;
     if (!_LoadFile(library, &m_Face, pFile, &stream)) {
-        return FALSE;
+        return false;
     }
     m_pOwnedStream = stream;
     FXFT_Set_Pixel_Sizes(m_Face, 0, 64);
-    return TRUE;
+    return true;
 }
 int CFX_Font::GetGlyphWidth(FX_DWORD glyph_index)
 {
     if (!m_Face) {
         return 0;
     }
     if (m_pSubstFont && (m_pSubstFont->m_SubstFlags & FXFONT_SUBST_MM)) {
         AdjustMMParams(glyph_index, 0, 0);
     }
     int err = FXFT_Load_Glyph(m_Face, glyph_index, FXFT_LOAD_NO_SCALE | FXFT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH);
@@ skipping 14 matching lines @@
     int error = FXFT_New_Memory_Face(library, pData, size, 0, &face);
     if (error) {
         return NULL;
     }
     error = FXFT_Set_Pixel_Sizes(face, 64, 64);
     if (error) {
         return NULL;
     }
     return face;
 }
-FX_BOOL CFX_Font::LoadEmbedded(const uint8_t* data, FX_DWORD size)
+bool CFX_Font::LoadEmbedded(const uint8_t* data, FX_DWORD size)
 {
     m_pFontDataAllocation = FX_Alloc(uint8_t, size);
     FXSYS_memcpy(m_pFontDataAllocation, data, size);
     m_Face = FT_LoadFont((uint8_t*)m_pFontDataAllocation, size);
     m_pFontData = (uint8_t*)m_pFontDataAllocation;
-    m_bEmbedded = TRUE;
+    m_bEmbedded = true;
     m_dwSize = size;
     return m_Face != NULL;
 }
-FX_BOOL CFX_Font::IsTTFont()
+bool CFX_Font::IsTTFont()
 {
     if (m_Face == NULL) {
-        return FALSE;
+        return false;
     }
     return FXFT_Is_Face_TT_OT(m_Face) == FXFT_FACE_FLAG_SFNT;
 }
 int CFX_Font::GetAscent() const
 {
     if (m_Face == NULL) {
         return 0;
     }
     int ascent = EM_ADJUST(FXFT_Get_Face_UnitsPerEM(m_Face), FXFT_Get_Face_Ascender(m_Face));
     return ascent;
 }
 int CFX_Font::GetDescent() const
 {
     if (m_Face == NULL) {
         return 0;
     }
     int descent = EM_ADJUST(FXFT_Get_Face_UnitsPerEM(m_Face), FXFT_Get_Face_Descender(m_Face));
     return descent;
 }
-FX_BOOL CFX_Font::GetGlyphBBox(FX_DWORD glyph_index, FX_RECT &bbox)
+bool CFX_Font::GetGlyphBBox(FX_DWORD glyph_index, FX_RECT &bbox)
 {
     if (m_Face == NULL) {
-        return FALSE;
+        return false;
     }
     if (FXFT_Is_Face_Tricky(m_Face)) {
         int error = FXFT_Set_Char_Size(m_Face, 0, 1000 * 64, 72, 72);
         if (error) {
-            return FALSE;
+            return false;
         }
         error = FXFT_Load_Glyph(m_Face, glyph_index, FXFT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH);
         if (error) {
-            return FALSE;
+            return false;
         }
         FXFT_BBox cbox;
         FT_Glyph glyph;
         error = FXFT_Get_Glyph(((FXFT_Face)m_Face)->glyph, &glyph);
         if (error) {
-            return FALSE;
+            return false;
         }
         FXFT_Glyph_Get_CBox(glyph, FXFT_GLYPH_BBOX_PIXELS, &cbox);
         int pixel_size_x = ((FXFT_Face)m_Face)->size->metrics.x_ppem,
             pixel_size_y = ((FXFT_Face)m_Face)->size->metrics.y_ppem;
         if (pixel_size_x == 0 || pixel_size_y == 0) {
             bbox.left = cbox.xMin;
             bbox.right = cbox.xMax;
             bbox.top = cbox.yMax;
             bbox.bottom = cbox.yMin;
         } else {
             bbox.left = cbox.xMin * 1000 / pixel_size_x;
             bbox.right = cbox.xMax * 1000 / pixel_size_x;
             bbox.top = cbox.yMax * 1000 / pixel_size_y;
             bbox.bottom = cbox.yMin * 1000 / pixel_size_y;
         }
         if (bbox.top > FXFT_Get_Face_Ascender(m_Face)) {
             bbox.top = FXFT_Get_Face_Ascender(m_Face);
         }
         if (bbox.bottom < FXFT_Get_Face_Descender(m_Face)) {
             bbox.bottom = FXFT_Get_Face_Descender(m_Face);
         }
         FT_Done_Glyph(glyph);
         return FXFT_Set_Pixel_Sizes(m_Face, 0, 64) == 0;
     }
     if (FXFT_Load_Glyph(m_Face, glyph_index, FXFT_LOAD_NO_SCALE | FXFT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH)) {
-        return FALSE;
+        return false;
     }
     int em = FXFT_Get_Face_UnitsPerEM(m_Face);
     if (em == 0) {
         bbox.left = FXFT_Get_Glyph_HoriBearingX(m_Face);
         bbox.bottom = FXFT_Get_Glyph_HoriBearingY(m_Face);
         bbox.top = bbox.bottom - FXFT_Get_Glyph_Height(m_Face);
         bbox.right = bbox.left + FXFT_Get_Glyph_Width(m_Face);
     } else {
         bbox.left = FXFT_Get_Glyph_HoriBearingX(m_Face) * 1000 / em;
         bbox.top = (FXFT_Get_Glyph_HoriBearingY(m_Face) - FXFT_Get_Glyph_Height(m_Face)) * 1000 / em;
         bbox.right = (FXFT_Get_Glyph_HoriBearingX(m_Face) + FXFT_Get_Glyph_Width(m_Face)) * 1000 / em;
         bbox.bottom = (FXFT_Get_Glyph_HoriBearingY(m_Face)) * 1000 / em;
     }
-    return TRUE;
+    return true;
 }
-FX_BOOL CFX_Font::IsItalic()
+bool CFX_Font::IsItalic()
 {
     if (m_Face == NULL) {
-        return FALSE;
+        return false;
     }
-    FX_BOOL ret = FXFT_Is_Face_Italic(m_Face) == FXFT_STYLE_FLAG_ITALIC;
+    bool ret = FXFT_Is_Face_Italic(m_Face) == FXFT_STYLE_FLAG_ITALIC;
     if (!ret) {
         CFX_ByteString str(FXFT_Get_Face_Style_Name(m_Face));
         str.MakeLower();
         if (str.Find("italic") != -1) {
-            ret = TRUE;
+            ret = true;
         }
     }
     return ret;
 }
-FX_BOOL CFX_Font::IsBold()
+bool CFX_Font::IsBold()
 {
     if (m_Face == NULL) {
-        return FALSE;
+        return false;
     }
     return FXFT_Is_Face_Bold(m_Face) == FXFT_STYLE_FLAG_BOLD;
 }
-FX_BOOL CFX_Font::IsFixedWidth()
+bool CFX_Font::IsFixedWidth()
 {
     if (m_Face == NULL) {
-        return FALSE;
+        return false;
     }
     return FXFT_Is_Face_fixedwidth(m_Face);
 }
 CFX_WideString CFX_Font::GetPsName() const
 {
     if (m_Face == NULL) {
         return CFX_WideString();
     }
     CFX_WideString psName = CFX_WideString::FromLocal(FXFT_Get_Postscript_Name(m_Face));
     if (psName.IsEmpty()) {
@@ skipping 25 matching lines @@
             facename = "Untitled";
         }
         if (!style.IsEmpty() && style != "Regular") {
             facename += " " + style;
         }
         return facename;
     } else {
         return m_pSubstFont->m_Family;
     }
 }
-FX_BOOL CFX_Font::GetBBox(FX_RECT &bbox)
+bool CFX_Font::GetBBox(FX_RECT &bbox)
 {
     if (m_Face == NULL) {
-        return FALSE;
+        return false;
     }
     int em = FXFT_Get_Face_UnitsPerEM(m_Face);
     if (em == 0) {
         bbox.left = FXFT_Get_Face_xMin(m_Face);
         bbox.bottom = FXFT_Get_Face_yMax(m_Face);
         bbox.top = FXFT_Get_Face_yMin(m_Face);
         bbox.right = FXFT_Get_Face_xMax(m_Face);
     } else {
         bbox.left = FXFT_Get_Face_xMin(m_Face) * 1000 / em;
         bbox.top = FXFT_Get_Face_yMin(m_Face) * 1000 / em;
         bbox.right = FXFT_Get_Face_xMax(m_Face) * 1000 / em;
         bbox.bottom = FXFT_Get_Face_yMax(m_Face) * 1000 / em;
     }
-    return TRUE;
+    return true;
 }
 int CFX_Font::GetHeight()
 {
     if (m_Face == NULL) {
         return 0;
     }
     int height = EM_ADJUST(FXFT_Get_Face_UnitsPerEM(m_Face), FXFT_Get_Face_Height(m_Face));
     return height;
 }
 int CFX_Font::GetMaxAdvanceWidth()
@@ skipping 62 matching lines @@
                 break;
             }
         }
     }
     return FXFT_Get_Char_Index(face, charcode);
 }
 IFX_FontEncoding* FXGE_CreateUnicodeEncoding(CFX_Font* pFont)
 {
     return new CFX_UnicodeEncoding(pFont);
 }