core/src/fpdfdoc/doc_action.cpp - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/doc_action.cpp

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfdoc/doc_action.cpp

diff --git a/core/src/fpdfdoc/doc_action.cpp b/core/src/fpdfdoc/doc_action.cpp

index da2e05af2e639d97319c8f468f6acaec38155760..4c113aab2b35ca510f1d895a3e5835a7f6675f58 100644

--- a/core/src/fpdfdoc/doc_action.cpp

+++ b/core/src/fpdfdoc/doc_action.cpp

@@ -282,10 +282,10 @@ const FX_CHAR* g_sAATypes[] = {"E", "X", "D", "U", "Fo", "Bl", "PO", "PC", "PV",

"WC", "WS", "DS", "WP", "DP",

};

-FX_BOOL CPDF_AAction::ActionExist(AActionType eType) const

+bool CPDF_AAction::ActionExist(AActionType eType) const

{

if (m_pDict == NULL) {

- return FALSE;

+ return false;

}

return m_pDict->KeyExist(g_sAATypes[(int)eType]);

}

« no previous file with comments | « core/src/fpdfapi/fpdf_render/render_int.h ('k') | core/src/fpdfdoc/doc_annot.cpp » ('j') | no next file with comments »