Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, mkwst+moarreviews-ipc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in extensions/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=yoz@chromium.org Committed: https://crrev.com/9168b2fe3e30afa4fd9a9500ba0725edf97c20a3 Cr-Commit-Position: refs/heads/master@{#300475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2222 lines, -2383 lines) Patch
M extensions/browser/api/api_resource_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.h View 18 chunks +36 lines, -36 lines 0 comments Download
M extensions/browser/api/app_view/app_view_internal_api.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/app_window/app_window_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/async_api_function.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_api.h View 6 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_api_pairing_delegate.h View 1 chunk +9 lines, -12 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_event_router.h View 2 chunks +19 lines, -20 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_extension_function.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_private_api.h View 4 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_private_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h View 17 chunks +34 lines, -34 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h View 2 chunks +18 lines, -21 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_notify_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_api.h View 14 chunks +47 lines, -47 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/capture_web_contents_function.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_api.h View 6 chunks +23 lines, -23 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_socket_unittest.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M extensions/browser/api/copresence_socket/copresence_socket_api.h View 6 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/api/copresence_socket/copresence_socket_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/declarative/declarative_api.h View 4 chunks +9 lines, -9 lines 0 comments Download
M extensions/browser/api/declarative/deduping_factory_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry_service.h View 2 chunks +13 lines, -15 lines 0 comments Download
M extensions/browser/api/declarative/test_rules_registry.h View 1 chunk +5 lines, -6 lines 0 comments Download
M extensions/browser/api/declarative_content/content_rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.h View 13 chunks +49 lines, -49 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h View 6 chunks +36 lines, -42 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h View 1 chunk +5 lines, -6 lines 0 comments Download
M extensions/browser/api/device_permissions_manager.h View 2 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/dns/dns_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/execute_code_function.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.h View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/hid/hid_api.h View 8 chunks +24 lines, -24 lines 0 comments Download
M extensions/browser/api/hid/hid_connection_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/power/power_api.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/power/power_api_manager.h View 2 chunks +5 lines, -6 lines 0 comments Download
M extensions/browser/api/power/power_api_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.h View 9 chunks +32 lines, -33 lines 0 comments Download
M extensions/browser/api/serial/serial_api.h View 12 chunks +36 lines, -36 lines 0 comments Download
M extensions/browser/api/serial/serial_apitest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/serial/serial_connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/serial/serial_connection.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M extensions/browser/api/serial/serial_event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/socket/socket.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/socket/socket_api.h View 23 chunks +69 lines, -69 lines 0 comments Download
M extensions/browser/api/socket/tcp_socket.h View 4 chunks +32 lines, -33 lines 0 comments Download
M extensions/browser/api/socket/tls_socket.h View 2 chunks +20 lines, -20 lines 0 comments Download
M extensions/browser/api/socket/udp_socket.h View 3 chunks +24 lines, -25 lines 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_api.h View 14 chunks +43 lines, -43 lines 0 comments Download
M extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h View 9 chunks +27 lines, -27 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_api.h View 15 chunks +46 lines, -46 lines 0 comments Download
M extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/leveldb_settings_storage_factory.h View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/browser/api/storage/local_value_store_cache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/api/storage/settings_storage_quota_enforcer.h View 1 chunk +17 lines, -18 lines 0 comments Download
M extensions/browser/api/storage/settings_test_util.h View 2 chunks +7 lines, -8 lines 0 comments Download
M extensions/browser/api/storage/storage_api.h View 6 chunks +16 lines, -19 lines 0 comments Download
M extensions/browser/api/storage/storage_frontend.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/storage_frontend.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/browser/api/storage/weak_unlimited_settings_storage.h View 1 chunk +17 lines, -18 lines 0 comments Download
M extensions/browser/api/system_cpu/cpu_info_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/system_cpu/system_cpu_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/system_info/system_info_api.h View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/browser/api/system_info/system_info_api.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/system_memory/memory_info_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/system_memory/system_memory_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/system_network/system_network_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/system_storage/storage_info_provider.h View 3 chunks +4 lines, -5 lines 0 comments Download
M extensions/browser/api/system_storage/system_storage_api.h View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/test/test_api.h View 7 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/api/usb/usb_api.h View 18 chunks +52 lines, -52 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M extensions/browser/api/usb/usb_device_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/form_data_parser.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter.h View 2 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.h View 5 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_time_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/api/web_view/web_view_internal_api.h View 20 chunks +49 lines, -49 lines 0 comments Download
M extensions/browser/api_test_utils.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/app_window/app_window.h View 3 chunks +45 lines, -52 lines 0 comments Download
M extensions/browser/app_window/app_window_contents.h View 1 chunk +10 lines, -11 lines 0 comments Download
M extensions/browser/app_window/app_window_geometry_cache.h View 4 chunks +11 lines, -12 lines 0 comments Download
M extensions/browser/app_window/app_window_registry.h View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/app_window/native_app_window.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/blob_holder.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/content_verifier.h View 1 chunk +6 lines, -7 lines 0 comments Download
M extensions/browser/event_listener_map_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/event_router.h View 3 chunks +11 lines, -12 lines 0 comments Download
M extensions/browser/event_router_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_error.h View 4 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/extension_function.h View 11 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/extension_function.cc View 8 chunks +15 lines, -17 lines 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/browser/extension_host.h View 2 chunks +24 lines, -29 lines 0 comments Download
M extensions/browser/extension_icon_image.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_icon_image.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_icon_image_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/extension_message_filter.h View 1 chunk +5 lines, -6 lines 0 comments Download
M extensions/browser/extension_pref_store.h View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_pref_value_map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_pref_value_map_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_prefs.h View 2 chunks +19 lines, -20 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/extension_prefs_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 8 chunks +15 lines, -17 lines 0 comments Download
M extensions/browser/extension_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_registry_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/extension_registry_unittest.cc View 1 chunk +14 lines, -19 lines 0 comments Download
M extensions/browser/extension_system.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_system_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_web_contents_observer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/file_highlighter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_guest.h View 1 chunk +14 lines, -16 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.h View 2 chunks +20 lines, -23 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 3 chunks +19 lines, -25 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.h View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 1 chunk +25 lines, -26 lines 0 comments Download
M extensions/browser/guest_view/test_guest_view_manager.h View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/guest_view/web_view/javascript_dialog_helper.h View 2 chunks +11 lines, -14 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 3 chunks +76 lines, -83 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper.h View 2 chunks +4 lines, -5 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/image_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/image_loader_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/browser/lazy_background_task_queue.h View 2 chunks +7 lines, -8 lines 0 comments Download
M extensions/browser/lazy_background_task_queue_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M extensions/browser/mock_extension_system.h View 1 chunk +22 lines, -23 lines 0 comments Download
M extensions/browser/null_app_sorting.h View 1 chunk +23 lines, -26 lines 0 comments Download
M extensions/browser/process_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/process_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/process_manager_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/process_map.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/process_map_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/quota_service.h View 3 chunks +5 lines, -7 lines 0 comments Download
M extensions/browser/quota_service_unittest.cc View 3 chunks +21 lines, -21 lines 0 comments Download
M extensions/browser/renderer_startup_helper.h View 2 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/runtime_data.h View 2 chunks +4 lines, -5 lines 0 comments Download
M extensions/browser/script_executor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/stash_backend.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/stash_backend_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/state_store.h View 3 chunks +12 lines, -14 lines 0 comments Download
M extensions/browser/test_extension_registry_observer.h View 2 chunks +14 lines, -17 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 2 chunks +38 lines, -43 lines 0 comments Download
M extensions/browser/test_management_policy.h View 1 chunk +12 lines, -12 lines 0 comments Download
M extensions/browser/test_runtime_api_delegate.h View 1 chunk +10 lines, -10 lines 0 comments Download
M extensions/browser/updater/extension_downloader.h View 3 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/updater/null_extension_cache.h View 1 chunk +11 lines, -11 lines 0 comments Download
M extensions/browser/updater/safe_manifest_parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/value_store/leveldb_value_store.h View 1 chunk +17 lines, -18 lines 0 comments Download
M extensions/browser/value_store/testing_value_store.h View 2 chunks +17 lines, -18 lines 0 comments Download
M extensions/browser/view_type_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/warning_service.h View 2 chunks +4 lines, -5 lines 0 comments Download
M extensions/browser/warning_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/bluetooth/bluetooth_manifest_data.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/bluetooth/bluetooth_manifest_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/common/api/bluetooth/bluetooth_manifest_permission.h View 2 chunks +10 lines, -13 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_data.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/sockets/sockets_manifest_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission.h View 2 chunks +10 lines, -13 lines 0 comments Download
M extensions/common/features/api_feature.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/features/base_feature_provider.h View 1 chunk +5 lines, -6 lines 0 comments Download
M extensions/common/features/complex_feature.h View 1 chunk +17 lines, -18 lines 0 comments Download
M extensions/common/features/manifest_feature.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/features/permission_feature.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/features/simple_feature.h View 2 chunks +21 lines, -21 lines 0 comments Download
M extensions/common/manifest_handler_unittest.cc View 5 chunks +11 lines, -18 lines 0 comments Download
M extensions/common/manifest_handlers/background_info.h View 2 chunks +8 lines, -8 lines 0 comments Download
M extensions/common/manifest_handlers/csp_info.h View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/common/manifest_handlers/externally_connectable.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/file_handler_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/icons_handler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M extensions/common/manifest_handlers/incognito_info.h View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/common/manifest_handlers/kiosk_mode_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/launcher_page_info.h View 1 chunk +6 lines, -6 lines 0 comments Download
M extensions/common/manifest_handlers/nacl_modules_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/manifest_handlers/oauth2_manifest_handler.h View 2 chunks +4 lines, -5 lines 0 comments Download
M extensions/common/manifest_handlers/offline_enabled_info.h View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/common/manifest_handlers/options_page_info.h View 2 chunks +7 lines, -7 lines 0 comments Download
M extensions/common/manifest_handlers/permissions_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/requirements_info.h View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/common/manifest_handlers/sandboxed_page_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/shared_module_info.h View 2 chunks +7 lines, -7 lines 0 comments Download
M extensions/common/manifest_handlers/web_accessible_resources_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/webview_info.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/manifest_url_handlers.h View 3 chunks +12 lines, -12 lines 0 comments Download
M extensions/common/permissions/api_permission.cc View 1 chunk +17 lines, -19 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.h View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/common/permissions/manifest_permission_set_unittest.cc View 1 chunk +9 lines, -18 lines 0 comments Download
M extensions/common/permissions/media_galleries_permission.h View 1 chunk +5 lines, -6 lines 0 comments Download
M extensions/common/permissions/settings_override_permission.h View 1 chunk +17 lines, -18 lines 0 comments Download
M extensions/common/permissions/socket_permission.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/usb_device_permission.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy.h View 1 chunk +9 lines, -9 lines 0 comments Download
M extensions/renderer/api/serial/serial_api_unittest.cc View 18 chunks +25 lines, -26 lines 0 comments Download
M extensions/renderer/api_test_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/api_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/app_window_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/binding_generating_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/console.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/content_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/default_dispatcher_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/dispatcher.h View 3 chunks +7 lines, -8 lines 0 comments Download
M extensions/renderer/event_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/extension_helper.h View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/extension_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/extensions_render_frame_observer.h View 1 chunk +7 lines, -7 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_container.h View 2 chunks +7 lines, -7 lines 0 comments Download
M extensions/renderer/logging_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/messaging_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/module_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/object_backed_native_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/programmatic_script_injector.h View 1 chunk +15 lines, -18 lines 0 comments Download
M extensions/renderer/render_view_observer_natives.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/renderer/resource_bundle_source_map.h View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/renderer/runtime_custom_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/safe_builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/script_context.h View 2 chunks +14 lines, -14 lines 0 comments Download
M extensions/renderer/script_injection_manager.h View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/renderer/script_injection_manager.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M extensions/renderer/static_v8_external_one_byte_string_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/test_extensions_renderer_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/user_script_injector.h View 1 chunk +17 lines, -21 lines 0 comments Download
M extensions/renderer/user_script_set_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/utils_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_extension_system.h View 2 chunks +25 lines, -26 lines 0 comments Download
M extensions/shell/test/shell_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/test/extension_test_message_listener.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/test/extensions_unittests_main.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/test/result_catcher.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/test/test_extensions_client.h View 1 chunk +19 lines, -22 lines 0 comments Download
M extensions/test/test_permission_message_provider.h View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
6 years, 2 months ago (2014-10-21 09:50:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664933004/1
6 years, 2 months ago (2014-10-21 09:51:43 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27531)
6 years, 2 months ago (2014-10-21 11:15:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664933004/1
6 years, 2 months ago (2014-10-21 11:19:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 12:38:34 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 13:10:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9168b2fe3e30afa4fd9a9500ba0725edf97c20a3
Cr-Commit-Position: refs/heads/master@{#300475}

Powered by Google App Engine
This is Rietveld 408576698