extensions/browser/api/socket/socket.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/socket.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/socket/socket.h

diff --git a/extensions/browser/api/socket/socket.h b/extensions/browser/api/socket/socket.h

index 255ee181c4b19fc643fcc3e0e42590439532e5fb..dce5216f4cbe4e3c5ac664000f163ec0ddfdca38 100644

--- a/extensions/browser/api/socket/socket.h

+++ b/extensions/browser/api/socket/socket.h

@@ -41,7 +41,7 @@ class Socket : public ApiResource {

public:

enum SocketType { TYPE_TCP, TYPE_UDP, TYPE_TLS };

- virtual ~Socket();

+ ~Socket() override;

// The hostname of the remote host that this socket is connected to. This

// may be the empty string if the client does not intend to ever upgrade the

« no previous file with comments | « extensions/browser/api/serial/serial_event_dispatcher.h ('k') | extensions/browser/api/socket/socket_api.h » ('j') | no next file with comments »