extensions/common/features/api_feature.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/api_feature.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/api/sockets/sockets_manifest_permission.h ('k') | extensions/common/features/base_feature_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/features/api_feature.h

diff --git a/extensions/common/features/api_feature.h b/extensions/common/features/api_feature.h

index 3cc86dbcc3ea348de26e3bc65c7335aa088e3527..7a30cb432d0f07602358b11952c89e01c8f9c243 100644

--- a/extensions/common/features/api_feature.h

+++ b/extensions/common/features/api_feature.h

@@ -14,12 +14,12 @@ namespace extensions {

class APIFeature : public SimpleFeature {

public:

APIFeature();

- virtual ~APIFeature();

+ ~APIFeature() override;

// extensions::Feature:

- virtual bool IsInternal() const override;

+ bool IsInternal() const override;

- virtual std::string Parse(const base::DictionaryValue* value) override;

+ std::string Parse(const base::DictionaryValue* value) override;

private:

bool internal_;

« no previous file with comments | « extensions/common/api/sockets/sockets_manifest_permission.h ('k') | extensions/common/features/base_feature_provider.h » ('j') | no next file with comments »