Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: extensions/browser/api/declarative/declarative_api.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative/declarative_api.h
diff --git a/extensions/browser/api/declarative/declarative_api.h b/extensions/browser/api/declarative/declarative_api.h
index acc2edf4c81e9c666deb0491126f1fa435d239d0..7f3b1a2dfe9018a697c806e05521da49afaa6eeb 100644
--- a/extensions/browser/api/declarative/declarative_api.h
+++ b/extensions/browser/api/declarative/declarative_api.h
@@ -17,11 +17,11 @@ class RulesFunction : public AsyncExtensionFunction {
RulesFunction();
protected:
- virtual ~RulesFunction();
+ ~RulesFunction() override;
// ExtensionFunction:
- virtual bool HasPermission() override;
- virtual bool RunAsync() override;
+ bool HasPermission() override;
+ bool RunAsync() override;
// Concrete implementation of the RulesFunction that is being called
// on the thread on which the respective RulesRegistry lives.
@@ -36,10 +36,10 @@ class EventsEventAddRulesFunction : public RulesFunction {
DECLARE_EXTENSION_FUNCTION("events.addRules", EVENTS_ADDRULES)
protected:
- virtual ~EventsEventAddRulesFunction() {}
+ ~EventsEventAddRulesFunction() override {}
// RulesFunction:
- virtual bool RunAsyncOnCorrectThread() override;
+ bool RunAsyncOnCorrectThread() override;
};
class EventsEventRemoveRulesFunction : public RulesFunction {
@@ -47,10 +47,10 @@ class EventsEventRemoveRulesFunction : public RulesFunction {
DECLARE_EXTENSION_FUNCTION("events.removeRules", EVENTS_REMOVERULES)
protected:
- virtual ~EventsEventRemoveRulesFunction() {}
+ ~EventsEventRemoveRulesFunction() override {}
// RulesFunction:
- virtual bool RunAsyncOnCorrectThread() override;
+ bool RunAsyncOnCorrectThread() override;
};
class EventsEventGetRulesFunction : public RulesFunction {
@@ -58,10 +58,10 @@ class EventsEventGetRulesFunction : public RulesFunction {
DECLARE_EXTENSION_FUNCTION("events.getRules", EVENTS_GETRULES)
protected:
- virtual ~EventsEventGetRulesFunction() {}
+ ~EventsEventGetRulesFunction() override {}
// RulesFunction:
- virtual bool RunAsyncOnCorrectThread() override;
+ bool RunAsyncOnCorrectThread() override;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698