extensions/renderer/api_test_base.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_test_base.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/api_test_base.h

diff --git a/extensions/renderer/api_test_base.h b/extensions/renderer/api_test_base.h

index 5cdff6f66eccc528b13b39b4c3de62b3beb4211e..c9a23e352430281f3eedd1f167157c7415ec0e0a 100644

--- a/extensions/renderer/api_test_base.h

+++ b/extensions/renderer/api_test_base.h

@@ -30,9 +30,9 @@ class V8SchemaRegistry;

class TestServiceProvider : public gin::Wrappable<TestServiceProvider> {

public:

static gin::Handle<TestServiceProvider> Create(v8::Isolate* isolate);

- virtual ~TestServiceProvider();

+ ~TestServiceProvider() override;

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

template <typename Interface>

« no previous file with comments | « extensions/renderer/api/serial/serial_api_unittest.cc ('k') | extensions/renderer/api_test_base.cc » ('j') | no next file with comments »