extensions/renderer/binding_generating_native_handler.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/binding_generating_native_handler.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/binding_generating_native_handler.h

diff --git a/extensions/renderer/binding_generating_native_handler.h b/extensions/renderer/binding_generating_native_handler.h

index 0c4061885e1e11f0fe60209521e300ba2133298a..fb71c54a45ca426304866c85100038d680eb5f13 100644

--- a/extensions/renderer/binding_generating_native_handler.h

+++ b/extensions/renderer/binding_generating_native_handler.h

@@ -25,7 +25,7 @@ class BindingGeneratingNativeHandler : public NativeHandler {

const std::string& api_name,

const std::string& bind_to);

- virtual v8::Handle<v8::Object> NewInstance() override;

+ v8::Handle<v8::Object> NewInstance() override;

private:

ModuleSystem* module_system_;

« no previous file with comments | « extensions/renderer/app_window_custom_bindings.cc ('k') | extensions/renderer/console.cc » ('j') | no next file with comments »