Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: extensions/common/features/simple_feature.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/permission_feature.h ('k') | extensions/common/manifest_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/simple_feature.h
diff --git a/extensions/common/features/simple_feature.h b/extensions/common/features/simple_feature.h
index 5cf2a10819c3f71f20e23b04b37bfd6cffb3b240..cb34108a0b9db9238caf8d69ea2efeb1c4b3c560 100644
--- a/extensions/common/features/simple_feature.h
+++ b/extensions/common/features/simple_feature.h
@@ -24,7 +24,7 @@ namespace extensions {
class SimpleFeature : public Feature {
public:
SimpleFeature();
- virtual ~SimpleFeature();
+ ~SimpleFeature() override;
// Similar to Manifest::Location, these are the classes of locations
// supported in feature files; "component" implies
@@ -89,26 +89,26 @@ class SimpleFeature : public Feature {
}
// extension::Feature:
- virtual Availability IsAvailableToManifest(const std::string& extension_id,
- Manifest::Type type,
- Manifest::Location location,
- int manifest_version,
- Platform platform) const override;
-
- virtual Availability IsAvailableToContext(const Extension* extension,
- Context context,
- const GURL& url,
- Platform platform) const override;
-
- virtual std::string GetAvailabilityMessage(AvailabilityResult result,
- Manifest::Type type,
- const GURL& url,
- Context context) const override;
-
- virtual bool IsInternal() const override;
-
- virtual bool IsIdInBlacklist(const std::string& extension_id) const override;
- virtual bool IsIdInWhitelist(const std::string& extension_id) const override;
+ Availability IsAvailableToManifest(const std::string& extension_id,
+ Manifest::Type type,
+ Manifest::Location location,
+ int manifest_version,
+ Platform platform) const override;
+
+ Availability IsAvailableToContext(const Extension* extension,
+ Context context,
+ const GURL& url,
+ Platform platform) const override;
+
+ std::string GetAvailabilityMessage(AvailabilityResult result,
+ Manifest::Type type,
+ const GURL& url,
+ Context context) const override;
+
+ bool IsInternal() const override;
+
+ bool IsIdInBlacklist(const std::string& extension_id) const override;
+ bool IsIdInWhitelist(const std::string& extension_id) const override;
static bool IsIdInList(const std::string& extension_id,
const std::set<std::string>& list);
« no previous file with comments | « extensions/common/features/permission_feature.h ('k') | extensions/common/manifest_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698