extensions/renderer/script_injection_manager.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injection_manager.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/script_injection_manager.h ('k') | extensions/renderer/static_v8_external_one_byte_string_resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/script_injection_manager.cc

diff --git a/extensions/renderer/script_injection_manager.cc b/extensions/renderer/script_injection_manager.cc

index 4c1efc5089cc034b0722ed76046a8718b23e9b88..436c4d00a0fd7e5c1f7f61d0fdf71fac148be73d 100644

--- a/extensions/renderer/script_injection_manager.cc

+++ b/extensions/renderer/script_injection_manager.cc

@@ -36,17 +36,17 @@ const int kScriptIdleTimeoutInMs = 200;

class ScriptInjectionManager::RVOHelper : public content::RenderViewObserver {

public:

RVOHelper(content::RenderView* render_view, ScriptInjectionManager* manager);

- virtual ~RVOHelper();

+ ~RVOHelper() override;

private:

// RenderViewObserver implementation.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void DidCreateDocumentElement(blink::WebLocalFrame* frame) override;

- virtual void DidFinishDocumentLoad(blink::WebLocalFrame* frame) override;

- virtual void DidFinishLoad(blink::WebLocalFrame* frame) override;

- virtual void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override;

- virtual void FrameDetached(blink::WebFrame* frame) override;

- virtual void OnDestruct() override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void DidCreateDocumentElement(blink::WebLocalFrame* frame) override;

+ void DidFinishDocumentLoad(blink::WebLocalFrame* frame) override;

+ void DidFinishLoad(blink::WebLocalFrame* frame) override;

+ void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override;

+ void FrameDetached(blink::WebFrame* frame) override;

+ void OnDestruct() override;

virtual void OnExecuteCode(const ExtensionMsg_ExecuteCode_Params& params);

virtual void OnExecuteDeclarativeScript(int tab_id,