Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: extensions/browser/api/usb/usb_apitest.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/usb/usb_api.h ('k') | extensions/browser/api/usb/usb_device_resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/usb/usb_apitest.cc
diff --git a/extensions/browser/api/usb/usb_apitest.cc b/extensions/browser/api/usb/usb_apitest.cc
index 62f6997def0346d9aa2664faca2a04e90586fd5b..7c63dcfd463d8ca5da29939e23a4f28d82d691ed 100644
--- a/extensions/browser/api/usb/usb_apitest.cc
+++ b/extensions/browser/api/usb/usb_apitest.cc
@@ -145,13 +145,12 @@ class MockUsbService : public UsbService {
explicit MockUsbService(scoped_refptr<UsbDevice> device) : device_(device) {}
protected:
- virtual scoped_refptr<UsbDevice> GetDeviceById(uint32 unique_id) override {
+ scoped_refptr<UsbDevice> GetDeviceById(uint32 unique_id) override {
EXPECT_EQ(unique_id, 0U);
return device_;
}
- virtual void GetDevices(
- std::vector<scoped_refptr<UsbDevice> >* devices) override {
+ void GetDevices(std::vector<scoped_refptr<UsbDevice>>* devices) override {
STLClearObject(devices);
devices->push_back(device_);
}
@@ -165,7 +164,7 @@ class MockUsbService : public UsbService {
class UsbApiTest : public ExtensionApiTest {
public:
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
mock_device_handle_ = new MockUsbDeviceHandle();
mock_device_ = new MockUsbDevice(mock_device_handle_.get());
scoped_refptr<content::MessageLoopRunner> runner =
@@ -181,7 +180,7 @@ class UsbApiTest : public ExtensionApiTest {
UsbService::SetInstanceForTest(new MockUsbService(mock_device_));
}
- virtual void TearDownOnMainThread() override {
+ void TearDownOnMainThread() override {
scoped_refptr<content::MessageLoopRunner> runner =
new content::MessageLoopRunner;
UsbService* service = NULL;
« no previous file with comments | « extensions/browser/api/usb/usb_api.h ('k') | extensions/browser/api/usb/usb_device_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698