Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Side by Side Diff: extensions/browser/lazy_background_task_queue_unittest.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/lazy_background_task_queue.h" 5 #include "extensions/browser/lazy_background_task_queue.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "components/keyed_service/content/browser_context_dependency_manager.h" 8 #include "components/keyed_service/content/browser_context_dependency_manager.h"
9 #include "content/public/browser/notification_service.h" 9 #include "content/public/browser/notification_service.h"
10 #include "content/public/test/test_browser_context.h" 10 #include "content/public/test/test_browser_context.h"
(...skipping 16 matching lines...) Expand all
27 27
28 // A ProcessManager that doesn't create background host pages. 28 // A ProcessManager that doesn't create background host pages.
29 class TestProcessManager : public ProcessManager { 29 class TestProcessManager : public ProcessManager {
30 public: 30 public:
31 explicit TestProcessManager(BrowserContext* context) 31 explicit TestProcessManager(BrowserContext* context)
32 : ProcessManager(context, context, ExtensionRegistry::Get(context)), 32 : ProcessManager(context, context, ExtensionRegistry::Get(context)),
33 create_count_(0) { 33 create_count_(0) {
34 // ProcessManager constructor above assumes non-incognito. 34 // ProcessManager constructor above assumes non-incognito.
35 DCHECK(!context->IsOffTheRecord()); 35 DCHECK(!context->IsOffTheRecord());
36 } 36 }
37 virtual ~TestProcessManager() {} 37 ~TestProcessManager() override {}
38 38
39 int create_count() { return create_count_; } 39 int create_count() { return create_count_; }
40 40
41 // ProcessManager overrides: 41 // ProcessManager overrides:
42 virtual bool CreateBackgroundHost(const Extension* extension, 42 bool CreateBackgroundHost(const Extension* extension,
43 const GURL& url) override { 43 const GURL& url) override {
44 // Don't actually try to create a web contents. 44 // Don't actually try to create a web contents.
45 create_count_++; 45 create_count_++;
46 return false; 46 return false;
47 } 47 }
48 48
49 private: 49 private:
50 int create_count_; 50 int create_count_;
51 51
52 DISALLOW_COPY_AND_ASSIGN(TestProcessManager); 52 DISALLOW_COPY_AND_ASSIGN(TestProcessManager);
53 }; 53 };
54 54
55 // A simple ExtensionSystem that returns a TestProcessManager. 55 // A simple ExtensionSystem that returns a TestProcessManager.
56 class MockExtensionSystemWithProcessManager : public MockExtensionSystem { 56 class MockExtensionSystemWithProcessManager : public MockExtensionSystem {
57 public: 57 public:
58 explicit MockExtensionSystemWithProcessManager(BrowserContext* context) 58 explicit MockExtensionSystemWithProcessManager(BrowserContext* context)
59 : MockExtensionSystem(context), test_process_manager_(context) {} 59 : MockExtensionSystem(context), test_process_manager_(context) {}
60 virtual ~MockExtensionSystemWithProcessManager() {} 60 ~MockExtensionSystemWithProcessManager() override {}
61 61
62 virtual ProcessManager* process_manager() override { 62 ProcessManager* process_manager() override { return &test_process_manager_; }
63 return &test_process_manager_;
64 }
65 63
66 private: 64 private:
67 TestProcessManager test_process_manager_; 65 TestProcessManager test_process_manager_;
68 }; 66 };
69 67
70 } // namespace 68 } // namespace
71 69
72 // Derives from ExtensionsTest to provide content module and keyed service 70 // Derives from ExtensionsTest to provide content module and keyed service
73 // initialization. 71 // initialization.
74 class LazyBackgroundTaskQueueTest : public ExtensionsTest { 72 class LazyBackgroundTaskQueueTest : public ExtensionsTest {
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 EXPECT_EQ(1u, queue.extensions_with_pending_tasks()); 211 EXPECT_EQ(1u, queue.extensions_with_pending_tasks());
214 212
215 // Processing tasks when there is one pending runs the task and removes the 213 // Processing tasks when there is one pending runs the task and removes the
216 // extension from the list of extensions with pending tasks. 214 // extension from the list of extensions with pending tasks.
217 queue.ProcessPendingTasks(NULL, browser_context(), extension.get()); 215 queue.ProcessPendingTasks(NULL, browser_context(), extension.get());
218 EXPECT_EQ(1, task_run_count()); 216 EXPECT_EQ(1, task_run_count());
219 EXPECT_EQ(0u, queue.extensions_with_pending_tasks()); 217 EXPECT_EQ(0u, queue.extensions_with_pending_tasks());
220 } 218 }
221 219
222 } // namespace extensions 220 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/lazy_background_task_queue.h ('k') | extensions/browser/mock_extension_system.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698