Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: extensions/common/permissions/manifest_permission_set_unittest.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/pickle.h" 5 #include "base/pickle.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "extensions/common/permissions/manifest_permission.h" 7 #include "extensions/common/permissions/manifest_permission.h"
8 #include "extensions/common/permissions/manifest_permission_set.h" 8 #include "extensions/common/permissions/manifest_permission_set.h"
9 #include "ipc/ipc_message.h" 9 #include "ipc/ipc_message.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 class MockManifestPermission : public ManifestPermission { 14 class MockManifestPermission : public ManifestPermission {
15 public: 15 public:
16 MockManifestPermission(const std::string& name) 16 MockManifestPermission(const std::string& name)
17 : name_(name) { 17 : name_(name) {
18 } 18 }
19 19
20 virtual std::string name() const override { 20 std::string name() const override { return name_; }
21 return name_;
22 }
23 21
24 virtual std::string id() const override { 22 std::string id() const override { return name(); }
25 return name();
26 }
27 23
28 virtual bool HasMessages() const override { 24 bool HasMessages() const override { return false; }
29 return false;
30 }
31 25
32 virtual PermissionMessages GetMessages() const override { 26 PermissionMessages GetMessages() const override {
33 return PermissionMessages(); 27 return PermissionMessages();
34 } 28 }
35 29
36 virtual bool FromValue(const base::Value* value) override { return true; } 30 bool FromValue(const base::Value* value) override { return true; }
37 31
38 virtual scoped_ptr<base::Value> ToValue() const override { 32 scoped_ptr<base::Value> ToValue() const override {
39 return make_scoped_ptr(base::Value::CreateNullValue()); 33 return make_scoped_ptr(base::Value::CreateNullValue());
40 } 34 }
41 35
42 virtual ManifestPermission* Diff(const ManifestPermission* rhs) 36 ManifestPermission* Diff(const ManifestPermission* rhs) const override {
43 const override {
44 const MockManifestPermission* other = 37 const MockManifestPermission* other =
45 static_cast<const MockManifestPermission*>(rhs); 38 static_cast<const MockManifestPermission*>(rhs);
46 EXPECT_EQ(name_, other->name_); 39 EXPECT_EQ(name_, other->name_);
47 return NULL; 40 return NULL;
48 } 41 }
49 42
50 virtual ManifestPermission* Union(const ManifestPermission* rhs) 43 ManifestPermission* Union(const ManifestPermission* rhs) const override {
51 const override {
52 const MockManifestPermission* other = 44 const MockManifestPermission* other =
53 static_cast<const MockManifestPermission*>(rhs); 45 static_cast<const MockManifestPermission*>(rhs);
54 EXPECT_EQ(name_, other->name_); 46 EXPECT_EQ(name_, other->name_);
55 return new MockManifestPermission(name_); 47 return new MockManifestPermission(name_);
56 } 48 }
57 49
58 virtual ManifestPermission* Intersect(const ManifestPermission* rhs) 50 ManifestPermission* Intersect(const ManifestPermission* rhs) const override {
59 const override {
60 const MockManifestPermission* other = 51 const MockManifestPermission* other =
61 static_cast<const MockManifestPermission*>(rhs); 52 static_cast<const MockManifestPermission*>(rhs);
62 EXPECT_EQ(name_, other->name_); 53 EXPECT_EQ(name_, other->name_);
63 return new MockManifestPermission(name_); 54 return new MockManifestPermission(name_);
64 } 55 }
65 56
66 private: 57 private:
67 std::string name_; 58 std::string name_;
68 }; 59 };
69 60
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 EXPECT_EQ(expected_permissions, result); 217 EXPECT_EQ(expected_permissions, result);
227 218
228 // |result| = |permissions1| - |permissions2| --> 219 // |result| = |permissions1| - |permissions2| -->
229 // |result| intersect |permissions2| == empty_set 220 // |result| intersect |permissions2| == empty_set
230 ManifestPermissionSet result2; 221 ManifestPermissionSet result2;
231 ManifestPermissionSet::Intersection(result, permissions2, &result2); 222 ManifestPermissionSet::Intersection(result, permissions2, &result2);
232 EXPECT_TRUE(result2.empty()); 223 EXPECT_TRUE(result2.empty());
233 } 224 }
234 225
235 } // namespace extensions 226 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/permissions/extensions_api_permissions.h ('k') | extensions/common/permissions/media_galleries_permission.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698