Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: extensions/common/manifest_handlers/options_page_info.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/options_page_info.h
diff --git a/extensions/common/manifest_handlers/options_page_info.h b/extensions/common/manifest_handlers/options_page_info.h
index 421165607742f1a6436a28abc8b95d0738c347ff..b448f6fc3bd71f7752b274f403f12721cfc7056b 100644
--- a/extensions/common/manifest_handlers/options_page_info.h
+++ b/extensions/common/manifest_handlers/options_page_info.h
@@ -25,7 +25,7 @@ class OptionsPageInfo : public Extension::ManifestData {
OptionsPageInfo(const GURL& options_page,
bool chrome_styles,
bool open_in_tab);
- virtual ~OptionsPageInfo();
+ ~OptionsPageInfo() override;
// Returns the URL to the given extension's options page. This method supports
// both the "options_ui.page" field and the legacy "options_page" field. If
@@ -69,15 +69,15 @@ class OptionsPageInfo : public Extension::ManifestData {
class OptionsPageManifestHandler : public ManifestHandler {
public:
OptionsPageManifestHandler();
- virtual ~OptionsPageManifestHandler();
+ ~OptionsPageManifestHandler() override;
- virtual bool Parse(Extension* extension, base::string16* error) override;
- virtual bool Validate(const Extension* extension,
- std::string* error,
- std::vector<InstallWarning>* warnings) const override;
+ bool Parse(Extension* extension, base::string16* error) override;
+ bool Validate(const Extension* extension,
+ std::string* error,
+ std::vector<InstallWarning>* warnings) const override;
private:
- virtual const std::vector<std::string> Keys() const override;
+ const std::vector<std::string> Keys() const override;
DISALLOW_COPY_AND_ASSIGN(OptionsPageManifestHandler);
};
« no previous file with comments | « extensions/common/manifest_handlers/offline_enabled_info.h ('k') | extensions/common/manifest_handlers/permissions_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698