extensions/common/manifest_handlers/offline_enabled_info.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/offline_enabled_info.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/manifest_handlers/oauth2_manifest_handler.h ('k') | extensions/common/manifest_handlers/options_page_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/offline_enabled_info.h

diff --git a/extensions/common/manifest_handlers/offline_enabled_info.h b/extensions/common/manifest_handlers/offline_enabled_info.h

index 6a1500f079356ba6e1d8eecf048467b09d56ec64..e1ba407294dc704c6430751dc5e55f13b910efa8 100644

--- a/extensions/common/manifest_handlers/offline_enabled_info.h

+++ b/extensions/common/manifest_handlers/offline_enabled_info.h

@@ -16,7 +16,7 @@ namespace extensions {

struct OfflineEnabledInfo : public Extension::ManifestData {

explicit OfflineEnabledInfo(bool offline_enabled);

- virtual ~OfflineEnabledInfo();

+ ~OfflineEnabledInfo() override;

// Whether the extension or app should be enabled when offline.

// Defaults to false, except for platform apps which are offline by default.

@@ -29,13 +29,13 @@ struct OfflineEnabledInfo : public Extension::ManifestData {

class OfflineEnabledHandler : public ManifestHandler {

public:

OfflineEnabledHandler();

- virtual ~OfflineEnabledHandler();

+ ~OfflineEnabledHandler() override;

- virtual bool Parse(Extension* extension, base::string16* error) override;

- virtual bool AlwaysParseForType(Manifest::Type type) const override;

+ bool Parse(Extension* extension, base::string16* error) override;

+ bool AlwaysParseForType(Manifest::Type type) const override;

private:

- virtual const std::vector<std::string> Keys() const override;

+ const std::vector<std::string> Keys() const override;

DISALLOW_COPY_AND_ASSIGN(OfflineEnabledHandler);

};