extensions/browser/api/storage/leveldb_settings_storage_factory.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/storage/leveldb_settings_storage_factory.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.h ('k') | extensions/browser/api/storage/local_value_store_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/storage/leveldb_settings_storage_factory.h

diff --git a/extensions/browser/api/storage/leveldb_settings_storage_factory.h b/extensions/browser/api/storage/leveldb_settings_storage_factory.h

index d755974d4a19561aba246e7408ada304d2a0a359..6f9cc569e1c3ed37ab122b868a98e76a1ecbf71b 100644

--- a/extensions/browser/api/storage/leveldb_settings_storage_factory.h

+++ b/extensions/browser/api/storage/leveldb_settings_storage_factory.h

@@ -12,15 +12,15 @@ namespace extensions {

// Factory for creating LeveldbValueStore instances.

class LeveldbSettingsStorageFactory : public SettingsStorageFactory {

public:

- virtual ValueStore* Create(const base::FilePath& base_path,

- const std::string& extension_id) override;

+ ValueStore* Create(const base::FilePath& base_path,

+ const std::string& extension_id) override;

- virtual void DeleteDatabaseIfExists(const base::FilePath& base_path,

- const std::string& extension_id) override;

+ void DeleteDatabaseIfExists(const base::FilePath& base_path,

+ const std::string& extension_id) override;

private:

// SettingsStorageFactory is refcounted.

- virtual ~LeveldbSettingsStorageFactory() {}

+ ~LeveldbSettingsStorageFactory() override {}

};

} // namespace extensions