extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h ('k') | extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_connection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

diff --git a/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc b/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

index cca4f0442347736c0d731e6c23e44389ed9eee20..c34399c84e4724348783cfd330c82e9d4c05ffe1 100644

--- a/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

+++ b/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

@@ -95,13 +95,13 @@ class BluetoothLowEnergyApiTest : public ExtensionApiTest {

virtual ~BluetoothLowEnergyApiTest() {}

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

ExtensionApiTest::SetUpOnMainThread();

empty_extension_ = extensions::test_util::CreateEmptyExtension();

SetUpMocks();

}

- virtual void TearDownOnMainThread() override {

+ void TearDownOnMainThread() override {

EXPECT_CALL(*mock_adapter_, RemoveObserver(_));

}