extensions/renderer/safe_builtins.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/safe_builtins.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/safe_builtins.cc

diff --git a/extensions/renderer/safe_builtins.cc b/extensions/renderer/safe_builtins.cc

index 8d99db5149b4727d76f30b2389604b0c108d97a8..f609359443b96dd1b8284a149d6103db6168dcda 100644

--- a/extensions/renderer/safe_builtins.cc

+++ b/extensions/renderer/safe_builtins.cc

@@ -146,7 +146,7 @@ class ExtensionImpl : public v8::Extension {

ExtensionImpl() : v8::Extension(kClassName, kScript) {}

private:

- virtual v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate(

+ v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate(

v8::Isolate* isolate,

v8::Handle<v8::String> name) override {

if (name->Equals(v8::String::NewFromUtf8(isolate, "Apply")))

« no previous file with comments | « extensions/renderer/runtime_custom_bindings.h ('k') | extensions/renderer/script_context.h » ('j') | no next file with comments »