extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h ('k') | extensions/browser/api/sockets_udp/sockets_udp_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h

diff --git a/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h

index d4d604c0dba7606eaaba5134cbe158e2fcb39600..bddfb8c42c386e7d14e1e2ffc978dbb9f03305f4 100644

--- a/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h

+++ b/extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h

@@ -28,7 +28,7 @@ class TCPServerSocketEventDispatcher

public base::SupportsWeakPtr<TCPServerSocketEventDispatcher> {

public:

explicit TCPServerSocketEventDispatcher(content::BrowserContext* context);

- virtual ~TCPServerSocketEventDispatcher();

+ ~TCPServerSocketEventDispatcher() override;

// Server socket is active, start accepting connections from it.

void OnServerSocketListen(const std::string& extension_id, int socket_id);