Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: extensions/renderer/static_v8_external_one_byte_string_resource.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_STATIC_V8_EXTERNAL_ONE_BYTE_STRING_RESOURCE_H_ 5 #ifndef EXTENSIONS_RENDERER_STATIC_V8_EXTERNAL_ONE_BYTE_STRING_RESOURCE_H_
6 #define EXTENSIONS_RENDERER_STATIC_V8_EXTERNAL_ONE_BYTE_STRING_RESOURCE_H_ 6 #define EXTENSIONS_RENDERER_STATIC_V8_EXTERNAL_ONE_BYTE_STRING_RESOURCE_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/strings/string_piece.h" 9 #include "base/strings/string_piece.h"
10 #include "v8/include/v8.h" 10 #include "v8/include/v8.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 // A very simple implementation of v8::ExternalAsciiStringResource that just 14 // A very simple implementation of v8::ExternalAsciiStringResource that just
15 // wraps a buffer. The buffer must outlive the v8 runtime instance this resource 15 // wraps a buffer. The buffer must outlive the v8 runtime instance this resource
16 // is used in. 16 // is used in.
17 class StaticV8ExternalOneByteStringResource 17 class StaticV8ExternalOneByteStringResource
18 : public v8::String::ExternalOneByteStringResource { 18 : public v8::String::ExternalOneByteStringResource {
19 public: 19 public:
20 explicit StaticV8ExternalOneByteStringResource( 20 explicit StaticV8ExternalOneByteStringResource(
21 const base::StringPiece& buffer); 21 const base::StringPiece& buffer);
22 virtual ~StaticV8ExternalOneByteStringResource(); 22 ~StaticV8ExternalOneByteStringResource() override;
23 23
24 virtual const char* data() const override; 24 const char* data() const override;
25 virtual size_t length() const override; 25 size_t length() const override;
26 26
27 private: 27 private:
28 base::StringPiece buffer_; 28 base::StringPiece buffer_;
29 }; 29 };
30 30
31 } // namespace extensions 31 } // namespace extensions
32 32
33 #endif // EXTENSIONS_RENDERER_STATIC_V8_EXTERNAL_ONE_BYTE_STRING_RESOURCE_H_ 33 #endif // EXTENSIONS_RENDERER_STATIC_V8_EXTERNAL_ONE_BYTE_STRING_RESOURCE_H_
OLDNEW
« no previous file with comments | « extensions/renderer/script_injection_manager.cc ('k') | extensions/renderer/test_extensions_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698