Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: extensions/browser/extension_function.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_error.h ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_function.h
diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h
index 43cb6111a699575ec2d56fd2a8249c5a6ebb127b..f4ffaa273afe5e96007c9a93b7eed5444f87844a 100644
--- a/extensions/browser/extension_function.h
+++ b/extensions/browser/extension_function.h
@@ -406,7 +406,7 @@ class UIThreadExtensionFunction : public ExtensionFunction {
UIThreadExtensionFunction();
- virtual UIThreadExtensionFunction* AsUIThreadExtensionFunction() override;
+ UIThreadExtensionFunction* AsUIThreadExtensionFunction() override;
void set_test_delegate(DelegateForTests* delegate) {
delegate_ = delegate;
@@ -453,9 +453,9 @@ class UIThreadExtensionFunction : public ExtensionFunction {
content::BrowserThread::UI>;
friend class base::DeleteHelper<UIThreadExtensionFunction>;
- virtual ~UIThreadExtensionFunction();
+ ~UIThreadExtensionFunction() override;
- virtual void SendResponse(bool success) override;
+ void SendResponse(bool success) override;
// Sets the Blob UUIDs whose ownership is being transferred to the renderer.
void SetTransferredBlobUUIDs(const std::vector<std::string>& blob_uuids);
@@ -477,7 +477,7 @@ class UIThreadExtensionFunction : public ExtensionFunction {
private:
class RenderHostTracker;
- virtual void Destruct() const override;
+ void Destruct() const override;
// TODO(tommycli): Remove once RenderViewHost is gone.
IPC::Sender* GetIPCSender();
@@ -501,7 +501,7 @@ class IOThreadExtensionFunction : public ExtensionFunction {
public:
IOThreadExtensionFunction();
- virtual IOThreadExtensionFunction* AsIOThreadExtensionFunction() override;
+ IOThreadExtensionFunction* AsIOThreadExtensionFunction() override;
void set_ipc_sender(
base::WeakPtr<extensions::ExtensionMessageFilter> ipc_sender,
@@ -528,11 +528,11 @@ class IOThreadExtensionFunction : public ExtensionFunction {
content::BrowserThread::IO>;
friend class base::DeleteHelper<IOThreadExtensionFunction>;
- virtual ~IOThreadExtensionFunction();
+ ~IOThreadExtensionFunction() override;
- virtual void Destruct() const override;
+ void Destruct() const override;
- virtual void SendResponse(bool success) override;
+ void SendResponse(bool success) override;
private:
base::WeakPtr<extensions::ExtensionMessageFilter> ipc_sender_;
@@ -548,7 +548,7 @@ class AsyncExtensionFunction : public UIThreadExtensionFunction {
AsyncExtensionFunction();
protected:
- virtual ~AsyncExtensionFunction();
+ ~AsyncExtensionFunction() override;
// Deprecated: Override UIThreadExtensionFunction and implement Run() instead.
//
@@ -561,7 +561,7 @@ class AsyncExtensionFunction : public UIThreadExtensionFunction {
static bool ValidationFailure(AsyncExtensionFunction* function);
private:
- virtual ResponseAction Run() override;
+ ResponseAction Run() override;
};
// A SyncExtensionFunction is an ExtensionFunction that runs synchronously
@@ -576,7 +576,7 @@ class SyncExtensionFunction : public UIThreadExtensionFunction {
SyncExtensionFunction();
protected:
- virtual ~SyncExtensionFunction();
+ ~SyncExtensionFunction() override;
// Deprecated: Override UIThreadExtensionFunction and implement Run() instead.
//
@@ -588,7 +588,7 @@ class SyncExtensionFunction : public UIThreadExtensionFunction {
static bool ValidationFailure(SyncExtensionFunction* function);
private:
- virtual ResponseAction Run() override;
+ ResponseAction Run() override;
};
class SyncIOThreadExtensionFunction : public IOThreadExtensionFunction {
@@ -596,7 +596,7 @@ class SyncIOThreadExtensionFunction : public IOThreadExtensionFunction {
SyncIOThreadExtensionFunction();
protected:
- virtual ~SyncIOThreadExtensionFunction();
+ ~SyncIOThreadExtensionFunction() override;
// Deprecated: Override IOThreadExtensionFunction and implement Run() instead.
//
@@ -609,7 +609,7 @@ class SyncIOThreadExtensionFunction : public IOThreadExtensionFunction {
static bool ValidationFailure(SyncIOThreadExtensionFunction* function);
private:
- virtual ResponseAction Run() override;
+ ResponseAction Run() override;
};
#endif // EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_
« no previous file with comments | « extensions/browser/extension_error.h ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698