extensions/browser/api/system_storage/storage_info_provider.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_storage/storage_info_provider.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/system_network/system_network_api.h ('k') | extensions/browser/api/system_storage/system_storage_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/system_storage/storage_info_provider.h

diff --git a/extensions/browser/api/system_storage/storage_info_provider.h b/extensions/browser/api/system_storage/storage_info_provider.h

index cd6f023b868f6b79c4a771a14bb7c4444f50ab14..8e18554d363a51fa629250cc8f0bcd525da8ee32 100644

--- a/extensions/browser/api/system_storage/storage_info_provider.h

+++ b/extensions/browser/api/system_storage/storage_info_provider.h

@@ -41,9 +41,8 @@ class StorageInfoProvider : public SystemInfoProvider {

static StorageInfoProvider* Get();

// SystemInfoProvider implementations

- virtual void PrepareQueryOnUIThread() override;

- virtual void InitializeProvider(

- const base::Closure& do_query_info_callback) override;

+ void PrepareQueryOnUIThread() override;

+ void InitializeProvider(const base::Closure& do_query_info_callback) override;

virtual double GetStorageFreeSpaceFromTransientIdOnFileThread(

const std::string& transient_id);

@@ -55,7 +54,7 @@ class StorageInfoProvider : public SystemInfoProvider {

protected:

StorageInfoProvider();

- virtual ~StorageInfoProvider();

+ ~StorageInfoProvider() override;

// Put all available storages' information into |info_|.

void GetAllStoragesIntoInfoList();

@@ -73,7 +72,7 @@ class StorageInfoProvider : public SystemInfoProvider {

// SystemInfoProvider implementations.

// Override to query the available capacity of all known storage devices on

// the blocking pool, including fixed and removable devices.

- virtual bool QueryInfo() override;

+ bool QueryInfo() override;

static base::LazyInstance<scoped_refptr<StorageInfoProvider> > provider_;