extensions/browser/api/system_cpu/cpu_info_provider.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_cpu/cpu_info_provider.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/storage/weak_unlimited_settings_storage.h ('k') | extensions/browser/api/system_cpu/system_cpu_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/system_cpu/cpu_info_provider.h

diff --git a/extensions/browser/api/system_cpu/cpu_info_provider.h b/extensions/browser/api/system_cpu/cpu_info_provider.h

index 3483d7f1f7a3127deabe25ffc4c5a7b3e4bff65e..e0544b74207b6d8b67e6fc2f1c9a1c38b95a3670 100644

--- a/extensions/browser/api/system_cpu/cpu_info_provider.h

+++ b/extensions/browser/api/system_cpu/cpu_info_provider.h

@@ -27,7 +27,7 @@ class CpuInfoProvider : public SystemInfoProvider {

friend class MockCpuInfoProviderImpl;

CpuInfoProvider();

- virtual ~CpuInfoProvider();

+ ~CpuInfoProvider() override;

// Platform specific implementation for querying the CPU time information

// for each processor.

@@ -35,7 +35,7 @@ class CpuInfoProvider : public SystemInfoProvider {

std::vector<linked_ptr<core_api::system_cpu::ProcessorInfo> >* infos);

// Overriden from SystemInfoProvider.

- virtual bool QueryInfo() override;

+ bool QueryInfo() override;

// Creates a list of codenames for currently active features.

std::vector<std::string> GetFeatures() const;