extensions/browser/api/app_window/app_window_api.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/app_window/app_window_api.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/app_view/app_view_internal_api.h ('k') | extensions/browser/api/app_window/app_window_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/app_window/app_window_api.h

diff --git a/extensions/browser/api/app_window/app_window_api.h b/extensions/browser/api/app_window/app_window_api.h

index d7ec927c166bbc1531bba0bd921907740d67f3f2..e8c9c811d7748d5b6aa1d7f489986a248a8a308b 100644

--- a/extensions/browser/api/app_window/app_window_api.h

+++ b/extensions/browser/api/app_window/app_window_api.h

@@ -22,8 +22,8 @@ class AppWindowCreateFunction : public AsyncExtensionFunction {

DECLARE_EXTENSION_FUNCTION("app.window.create", APP_WINDOW_CREATE)

protected:

- virtual ~AppWindowCreateFunction() {}

- virtual bool RunAsync() override;

+ ~AppWindowCreateFunction() override {}

+ bool RunAsync() override;

private:

bool GetBoundsSpec(

« no previous file with comments | « extensions/browser/api/app_view/app_view_internal_api.h ('k') | extensions/browser/api/app_window/app_window_apitest.cc » ('j') | no next file with comments »