Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: extensions/renderer/script_context.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/safe_builtins.cc ('k') | extensions/renderer/script_injection_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context.h
diff --git a/extensions/renderer/script_context.h b/extensions/renderer/script_context.h
index 5c40dfb67951761eaffb43cf1cd19ef2667dad9a..8d6f853e9e5ca43832cfee2092db26b3e7f4ee8e 100644
--- a/extensions/renderer/script_context.h
+++ b/extensions/renderer/script_context.h
@@ -38,7 +38,7 @@ class ScriptContext : public RequestSender::Source, public gin::Runner {
Feature::Context context_type,
const Extension* effective_extension,
Feature::Context effective_context_type);
- virtual ~ScriptContext();
+ ~ScriptContext() override;
// Clears the WebFrame for this contexts and invalidates the associated
// ModuleSystem.
@@ -133,21 +133,21 @@ class ScriptContext : public RequestSender::Source, public gin::Runner {
bool match_about_blank);
// RequestSender::Source implementation.
- virtual ScriptContext* GetContext() override;
- virtual void OnResponseReceived(const std::string& name,
- int request_id,
- bool success,
- const base::ListValue& response,
- const std::string& error) override;
+ ScriptContext* GetContext() override;
+ void OnResponseReceived(const std::string& name,
+ int request_id,
+ bool success,
+ const base::ListValue& response,
+ const std::string& error) override;
// gin::Runner overrides.
- virtual void Run(const std::string& source,
- const std::string& resource_name) override;
- virtual v8::Handle<v8::Value> Call(v8::Handle<v8::Function> function,
- v8::Handle<v8::Value> receiver,
- int argc,
- v8::Handle<v8::Value> argv[]) override;
- virtual gin::ContextHolder* GetContextHolder() override;
+ void Run(const std::string& source,
+ const std::string& resource_name) override;
+ v8::Handle<v8::Value> Call(v8::Handle<v8::Function> function,
+ v8::Handle<v8::Value> receiver,
+ int argc,
+ v8::Handle<v8::Value> argv[]) override;
+ gin::ContextHolder* GetContextHolder() override;
protected:
// The v8 context the bindings are accessible to.
« no previous file with comments | « extensions/renderer/safe_builtins.cc ('k') | extensions/renderer/script_injection_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698