Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.h
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h
index 1aeca3649a2c8874c8da5cf2f273926a03b58487..bd4286cdd6467d112a0f535a60443ea01d8a4144 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h
@@ -27,33 +27,30 @@ class ExtensionOptionsGuest
int guest_instance_id);
// GuestViewBase implementation.
- virtual void CreateWebContents(
- const std::string& embedder_extension_id,
- int embedder_render_process_id,
- const GURL& embedder_site_url,
- const base::DictionaryValue& create_params,
- const WebContentsCreatedCallback& callback) override;
- virtual void DidAttachToEmbedder() override;
- virtual void DidInitialize() override;
- virtual void DidStopLoading() override;
- virtual const char* GetAPINamespace() const override;
- virtual int GetTaskPrefix() const override;
- virtual void GuestSizeChangedDueToAutoSize(
- const gfx::Size& old_size,
- const gfx::Size& new_size) override;
- virtual bool IsAutoSizeSupported() const override;
+ void CreateWebContents(const std::string& embedder_extension_id,
+ int embedder_render_process_id,
+ const GURL& embedder_site_url,
+ const base::DictionaryValue& create_params,
+ const WebContentsCreatedCallback& callback) override;
+ void DidAttachToEmbedder() override;
+ void DidInitialize() override;
+ void DidStopLoading() override;
+ const char* GetAPINamespace() const override;
+ int GetTaskPrefix() const override;
+ void GuestSizeChangedDueToAutoSize(const gfx::Size& old_size,
+ const gfx::Size& new_size) override;
+ bool IsAutoSizeSupported() const override;
// ExtensionFunctionDispatcher::Delegate implementation.
- virtual content::WebContents* GetAssociatedWebContents() const override;
+ content::WebContents* GetAssociatedWebContents() const override;
// content::WebContentsDelegate implementation.
- virtual content::WebContents* OpenURLFromTab(
+ content::WebContents* OpenURLFromTab(
content::WebContents* source,
const content::OpenURLParams& params) override;
- virtual void CloseContents(content::WebContents* source) override;
- virtual bool HandleContextMenu(
- const content::ContextMenuParams& params) override;
- virtual bool ShouldCreateWebContents(
+ void CloseContents(content::WebContents* source) override;
+ bool HandleContextMenu(const content::ContextMenuParams& params) override;
+ bool ShouldCreateWebContents(
content::WebContents* web_contents,
int route_id,
WindowContainerType window_container_type,
@@ -63,12 +60,12 @@ class ExtensionOptionsGuest
content::SessionStorageNamespace* session_storage_namespace) override;
// content::WebContentsObserver implementation.
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& message) override;
private:
ExtensionOptionsGuest(content::BrowserContext* browser_context,
int guest_instance_id);
- virtual ~ExtensionOptionsGuest();
+ ~ExtensionOptionsGuest() override;
void OnRequest(const ExtensionHostMsg_Request_Params& params);
void SetUpAutoSize();
« no previous file with comments | « extensions/browser/guest_view/app_view/app_view_guest.h ('k') | extensions/browser/guest_view/guest_view_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698