extensions/browser/api/copresence_socket/copresence_socket_api.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/copresence_socket/copresence_socket_api.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/copresence_socket/copresence_socket_api.h ('k') | extensions/browser/api/declarative/declarative_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/copresence_socket/copresence_socket_api.cc

diff --git a/extensions/browser/api/copresence_socket/copresence_socket_api.cc b/extensions/browser/api/copresence_socket/copresence_socket_api.cc

index 07042977f36248a0185f8ae51d645d63d02445fb..8bdd7fbf21fb82704afecbdc328578b74ba025e5 100644

--- a/extensions/browser/api/copresence_socket/copresence_socket_api.cc

+++ b/extensions/browser/api/copresence_socket/copresence_socket_api.cc

@@ -24,7 +24,7 @@ class CopresencePeerResource : public ApiResource {

scoped_ptr<copresence_sockets::CopresencePeer> peer)

: ApiResource(owner_extension_id), peer_(peer.Pass()) {}

- virtual ~CopresencePeerResource() {}

+ ~CopresencePeerResource() override {}

copresence_sockets::CopresencePeer* peer() { return peer_.get(); }

@@ -45,7 +45,7 @@ class CopresenceSocketResource : public ApiResource {

scoped_ptr<copresence_sockets::CopresenceSocket> socket)

: ApiResource(owner_extension_id), socket_(socket.Pass()) {}

- virtual ~CopresenceSocketResource() {}

+ ~CopresenceSocketResource() override {}

copresence_sockets::CopresenceSocket* socket() { return socket_.get(); }