extensions/browser/api/system_info/system_info_api.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_info/system_info_api.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/system_info/system_info_api.h ('k') | extensions/browser/api/system_memory/memory_info_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/system_info/system_info_api.cc

diff --git a/extensions/browser/api/system_info/system_info_api.cc b/extensions/browser/api/system_info/system_info_api.cc

index 488dc410520e6fa950a58fe321093ef66f4c7481..3a1c1b5f513dc3a2309dccbb46ca84440754d25b 100644

--- a/extensions/browser/api/system_info/system_info_api.cc

+++ b/extensions/browser/api/system_info/system_info_api.cc

@@ -53,7 +53,7 @@ class SystemInfoEventRouter : public gfx::DisplayObserver,

static SystemInfoEventRouter* GetInstance();

SystemInfoEventRouter();

- virtual ~SystemInfoEventRouter();

+ ~SystemInfoEventRouter() override;

// Add/remove event listener for the |event_name| event.

void AddEventListener(const std::string& event_name);

@@ -61,15 +61,15 @@ class SystemInfoEventRouter : public gfx::DisplayObserver,

private:

// gfx::DisplayObserver:

- virtual void OnDisplayAdded(const gfx::Display& new_display) override;

- virtual void OnDisplayRemoved(const gfx::Display& old_display) override;

- virtual void OnDisplayMetricsChanged(const gfx::Display& display,

- uint32_t metrics) override;

+ void OnDisplayAdded(const gfx::Display& new_display) override;

+ void OnDisplayRemoved(const gfx::Display& old_display) override;

+ void OnDisplayMetricsChanged(const gfx::Display& display,

+ uint32_t metrics) override;

// RemovableStorageObserver implementation.

- virtual void OnRemovableStorageAttached(

+ void OnRemovableStorageAttached(

const storage_monitor::StorageInfo& info) override;

- virtual void OnRemovableStorageDetached(

+ void OnRemovableStorageDetached(

const storage_monitor::StorageInfo& info) override;

// Called from any thread to dispatch the systemInfo event to all extension