extensions/browser/view_type_utils.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/view_type_utils.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/view_type_utils.cc

diff --git a/extensions/browser/view_type_utils.cc b/extensions/browser/view_type_utils.cc

index 5179a055772a2961a1d5ec7e5229148713528bd5..ba72ceb7de7f3aa8ae0697415020286176220fac 100644

--- a/extensions/browser/view_type_utils.cc

+++ b/extensions/browser/view_type_utils.cc

@@ -18,7 +18,7 @@ const char kViewTypeUserDataKey[] = "ViewTypeUserData";

class ViewTypeUserData : public base::SupportsUserData::Data {

public:

explicit ViewTypeUserData(ViewType type) : type_(type) {}

- virtual ~ViewTypeUserData() {}

+ ~ViewTypeUserData() override {}

ViewType type() { return type_; }

private:

« no previous file with comments | « extensions/browser/value_store/testing_value_store.h ('k') | extensions/browser/warning_service.h » ('j') | no next file with comments »