extensions/renderer/api_test_base.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_test_base.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/api_test_base.cc

diff --git a/extensions/renderer/api_test_base.cc b/extensions/renderer/api_test_base.cc

index 6c364c9d76f3554373d317f06a86bc3ea4edf94f..7e3dd7ba8079aab7f1fe4a215aa42ee97fa381dc 100644

--- a/extensions/renderer/api_test_base.cc

+++ b/extensions/renderer/api_test_base.cc

@@ -30,7 +30,7 @@ class TestNatives : public gin::Wrappable<TestNatives> {

return gin::CreateHandle(isolate, new TestNatives(quit_closure));

}

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override {

return Wrappable<TestNatives>::GetObjectTemplateBuilder(isolate)

.SetMethod("Log", &TestNatives::Log)

« no previous file with comments | « extensions/renderer/api_test_base.h ('k') | extensions/renderer/app_window_custom_bindings.cc » ('j') | no next file with comments »