Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.h ('k') | extensions/browser/guest_view/guest_view_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/guest_view_base.cc
diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc
index 0dba70c50476ea42af872ef241d381d454f3691c..2fbbf603020c336a136e2271ac121090f84d6d1e 100644
--- a/extensions/browser/guest_view/guest_view_base.cc
+++ b/extensions/browser/guest_view/guest_view_base.cc
@@ -65,21 +65,21 @@ class GuestViewBase::EmbedderLifetimeObserver : public WebContentsObserver {
destroyed_(false),
guest_(guest) {}
- virtual ~EmbedderLifetimeObserver() {}
+ ~EmbedderLifetimeObserver() override {}
// WebContentsObserver implementation.
- virtual void WebContentsDestroyed() override {
+ void WebContentsDestroyed() override {
// If the embedder is destroyed then destroy the guest.
Destroy();
}
- virtual void AboutToNavigateRenderView(
+ void AboutToNavigateRenderView(
content::RenderViewHost* render_view_host) override {
// If the embedder navigates then destroy the guest.
Destroy();
}
- virtual void RenderProcessGone(base::TerminationStatus status) override {
+ void RenderProcessGone(base::TerminationStatus status) override {
// If the embedder crashes, then destroy the guest.
Destroy();
}
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.h ('k') | extensions/browser/guest_view/guest_view_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698