Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.h
diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.h b/extensions/browser/guest_view/web_view/javascript_dialog_helper.h
index 5b6cc6a6c8ed0bca0ee0e0e15ed59717ea31c871..50c89efd44e9318fc7d07dfd8c49d86e49ad456a 100644
--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.h
+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.h
@@ -14,10 +14,10 @@ class WebViewGuest;
class JavaScriptDialogHelper : public content::JavaScriptDialogManager {
public:
explicit JavaScriptDialogHelper(WebViewGuest* guest);
- virtual ~JavaScriptDialogHelper();
+ ~JavaScriptDialogHelper() override;
// JavaScriptDialogManager implementation.
- virtual void RunJavaScriptDialog(
+ void RunJavaScriptDialog(
content::WebContents* web_contents,
const GURL& origin_url,
const std::string& accept_lang,
@@ -26,19 +26,16 @@ class JavaScriptDialogHelper : public content::JavaScriptDialogManager {
const base::string16& default_prompt_text,
const DialogClosedCallback& callback,
bool* did_suppress_message) override;
- virtual void RunBeforeUnloadDialog(
- content::WebContents* web_contents,
- const base::string16& message_text,
- bool is_reload,
- const DialogClosedCallback& callback) override;
- virtual bool HandleJavaScriptDialog(
- content::WebContents* web_contents,
- bool accept,
- const base::string16* prompt_override) override;
- virtual void CancelActiveAndPendingDialogs(
- content::WebContents* web_contents) override;
- virtual void WebContentsDestroyed(
+ void RunBeforeUnloadDialog(content::WebContents* web_contents,
+ const base::string16& message_text,
+ bool is_reload,
+ const DialogClosedCallback& callback) override;
+ bool HandleJavaScriptDialog(content::WebContents* web_contents,
+ bool accept,
+ const base::string16* prompt_override) override;
+ void CancelActiveAndPendingDialogs(
content::WebContents* web_contents) override;
+ void WebContentsDestroyed(content::WebContents* web_contents) override;
private:
void OnPermissionResponse(
« no previous file with comments | « extensions/browser/guest_view/test_guest_view_manager.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698