extensions/browser/api/declarative/deduping_factory_unittest.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/deduping_factory_unittest.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/declarative_api.h ('k') | extensions/browser/api/declarative/rules_registry_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative/deduping_factory_unittest.cc

diff --git a/extensions/browser/api/declarative/deduping_factory_unittest.cc b/extensions/browser/api/declarative/deduping_factory_unittest.cc

index dfe30f59eaeaad68c41c4e48973fb0390d79bce0..a10cb9c512749d3d0609c3e47e870fd9c9277387 100644

--- a/extensions/browser/api/declarative/deduping_factory_unittest.cc

+++ b/extensions/browser/api/declarative/deduping_factory_unittest.cc

@@ -38,7 +38,7 @@ class BaseClass : public base::RefCounted<BaseClass> {

class Foo : public BaseClass {

public:

explicit Foo(int parameter) : BaseClass(FOO), parameter_(parameter) {}

- virtual bool Equals(const BaseClass* other) const override {

+ bool Equals(const BaseClass* other) const override {

return other->type() == type() &&

static_cast<const Foo*>(other)->parameter_ == parameter_;

}

@@ -48,7 +48,7 @@ class Foo : public BaseClass {

private:

friend class base::RefCounted<BaseClass>;

- virtual ~Foo() {}

+ ~Foo() override {}

// Note that this class must be immutable.

const int parameter_;