Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3278)

Unified Diff: extensions/browser/app_window/app_window_geometry_cache.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window_geometry_cache.h
diff --git a/extensions/browser/app_window/app_window_geometry_cache.h b/extensions/browser/app_window/app_window_geometry_cache.h
index a0cd10c8eb6fe02146284acbebaf51b9e6baabac..cc1d07670f4c52c68ec301cf293b4d9d3618b7d6 100644
--- a/extensions/browser/app_window/app_window_geometry_cache.h
+++ b/extensions/browser/app_window/app_window_geometry_cache.h
@@ -45,13 +45,13 @@ class AppWindowGeometryCache : public KeyedService,
friend struct DefaultSingletonTraits<Factory>;
Factory();
- virtual ~Factory();
+ ~Factory() override;
// BrowserContextKeyedServiceFactory
- virtual KeyedService* BuildServiceInstanceFor(
+ KeyedService* BuildServiceInstanceFor(
content::BrowserContext* context) const override;
- virtual bool ServiceIsNULLWhileTesting() const override;
- virtual content::BrowserContext* GetBrowserContextToUse(
+ bool ServiceIsNULLWhileTesting() const override;
+ content::BrowserContext* GetBrowserContextToUse(
content::BrowserContext* context) const override;
};
@@ -68,7 +68,7 @@ class AppWindowGeometryCache : public KeyedService,
AppWindowGeometryCache(content::BrowserContext* context,
ExtensionPrefs* prefs);
- virtual ~AppWindowGeometryCache();
+ ~AppWindowGeometryCache() override;
// Returns the instance for the given browsing context.
static AppWindowGeometryCache* Get(content::BrowserContext* context);
@@ -90,7 +90,7 @@ class AppWindowGeometryCache : public KeyedService,
ui::WindowShowState* state);
// KeyedService
- virtual void Shutdown() override;
+ void Shutdown() override;
void AddObserver(Observer* observer);
void RemoveObserver(Observer* observer);
@@ -121,12 +121,11 @@ class AppWindowGeometryCache : public KeyedService,
typedef std::map<std::string, WindowData> ExtensionData;
// ExtensionRegistryObserver implementation.
- virtual void OnExtensionLoaded(content::BrowserContext* browser_context,
- const Extension* extension) override;
- virtual void OnExtensionUnloaded(
- content::BrowserContext* browser_context,
- const Extension* extension,
- UnloadedExtensionInfo::Reason reason) override;
+ void OnExtensionLoaded(content::BrowserContext* browser_context,
+ const Extension* extension) override;
+ void OnExtensionUnloaded(content::BrowserContext* browser_context,
+ const Extension* extension,
+ UnloadedExtensionInfo::Reason reason) override;
void LoadGeometryFromStorage(const std::string& extension_id);
void SyncToStorage();
« no previous file with comments | « extensions/browser/app_window/app_window_contents.h ('k') | extensions/browser/app_window/app_window_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698