Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: extensions/browser/api/test/test_api.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/system_storage/system_storage_api.h ('k') | extensions/browser/api/usb/usb_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/test/test_api.h
diff --git a/extensions/browser/api/test/test_api.h b/extensions/browser/api/test/test_api.h
index dd465b0438daa015739be25d436aea307e49394c..b35ba32f7d08c653ce7a779c423a5238a1041a26 100644
--- a/extensions/browser/api/test/test_api.h
+++ b/extensions/browser/api/test/test_api.h
@@ -17,10 +17,10 @@ namespace extensions {
// Prior to running, checks that we are in a testing process.
class TestExtensionFunction : public SyncExtensionFunction {
protected:
- virtual ~TestExtensionFunction();
+ ~TestExtensionFunction() override;
// SyncExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
virtual bool RunSafe() = 0;
};
@@ -30,10 +30,10 @@ class TestNotifyPassFunction : public TestExtensionFunction {
DECLARE_EXTENSION_FUNCTION("test.notifyPass", UNKNOWN)
protected:
- virtual ~TestNotifyPassFunction();
+ ~TestNotifyPassFunction() override;
// TestExtensionFunction:
- virtual bool RunSafe() override;
+ bool RunSafe() override;
};
class TestNotifyFailFunction : public TestExtensionFunction {
@@ -41,10 +41,10 @@ class TestNotifyFailFunction : public TestExtensionFunction {
DECLARE_EXTENSION_FUNCTION("test.notifyFail", UNKNOWN)
protected:
- virtual ~TestNotifyFailFunction();
+ ~TestNotifyFailFunction() override;
// TestExtensionFunction:
- virtual bool RunSafe() override;
+ bool RunSafe() override;
};
class TestLogFunction : public TestExtensionFunction {
@@ -52,10 +52,10 @@ class TestLogFunction : public TestExtensionFunction {
DECLARE_EXTENSION_FUNCTION("test.log", UNKNOWN)
protected:
- virtual ~TestLogFunction();
+ ~TestLogFunction() override;
// TestExtensionFunction:
- virtual bool RunSafe() override;
+ bool RunSafe() override;
};
class TestSendMessageFunction : public AsyncExtensionFunction {
@@ -70,10 +70,10 @@ class TestSendMessageFunction : public AsyncExtensionFunction {
void ReplyWithError(const std::string& error);
protected:
- virtual ~TestSendMessageFunction();
+ ~TestSendMessageFunction() override;
// ExtensionFunction:
- virtual bool RunAsync() override;
+ bool RunAsync() override;
};
class TestGetConfigFunction : public TestExtensionFunction {
@@ -108,10 +108,10 @@ class TestGetConfigFunction : public TestExtensionFunction {
DISALLOW_COPY_AND_ASSIGN(TestConfigState);
};
- virtual ~TestGetConfigFunction();
+ ~TestGetConfigFunction() override;
// TestExtensionFunction:
- virtual bool RunSafe() override;
+ bool RunSafe() override;
};
class TestWaitForRoundTripFunction : public TestExtensionFunction {
@@ -119,10 +119,10 @@ class TestWaitForRoundTripFunction : public TestExtensionFunction {
DECLARE_EXTENSION_FUNCTION("test.waitForRoundTrip", UNKNOWN)
protected:
- virtual ~TestWaitForRoundTripFunction();
+ ~TestWaitForRoundTripFunction() override;
// TestExtensionFunction:
- virtual bool RunSafe() override;
+ bool RunSafe() override;
};
} // namespace extensions
« no previous file with comments | « extensions/browser/api/system_storage/system_storage_api.h ('k') | extensions/browser/api/usb/usb_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698