extensions/browser/stash_backend_unittest.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/stash_backend_unittest.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/stash_backend_unittest.cc

diff --git a/extensions/browser/stash_backend_unittest.cc b/extensions/browser/stash_backend_unittest.cc

index 5a30d522c83885e071738af86e84bf1ee632bc9c..04c52339c4e14bda4f3a1b4c58a078702974574e 100644

--- a/extensions/browser/stash_backend_unittest.cc

+++ b/extensions/browser/stash_backend_unittest.cc

@@ -27,9 +27,7 @@ class StashServiceTest : public testing::Test, public mojo::ErrorHandler {

stash_service_.set_error_handler(this);

}

- virtual void OnConnectionError() override {

- FAIL() << "Unexpected connection error";

- }

+ void OnConnectionError() override { FAIL() << "Unexpected connection error"; }

mojo::Array<StashedObjectPtr> RetrieveStash() {

mojo::Array<StashedObjectPtr> stash;

« no previous file with comments | « extensions/browser/stash_backend.cc ('k') | extensions/browser/state_store.h » ('j') | no next file with comments »