extensions/common/permissions/media_galleries_permission.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/media_galleries_permission.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/manifest_permission_set_unittest.cc ('k') | extensions/common/permissions/settings_override_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/media_galleries_permission.h

diff --git a/extensions/common/permissions/media_galleries_permission.h b/extensions/common/permissions/media_galleries_permission.h

index 29a7b30ea6be9fec80cfb1e0340e640aa281231d..dfaed1b05f27fe57c35c245e725cebb96308b553 100644

--- a/extensions/common/permissions/media_galleries_permission.h

+++ b/extensions/common/permissions/media_galleries_permission.h

@@ -33,18 +33,17 @@ class MediaGalleriesPermission

};

explicit MediaGalleriesPermission(const APIPermissionInfo* info);

- virtual ~MediaGalleriesPermission();

+ ~MediaGalleriesPermission() override;

// SetDisjunctionPermission overrides.

// MediaGalleriesPermission does additional checks to make sure the

// permissions do not contain unknown values.

- virtual bool FromValue(

- const base::Value* value,

- std::string* error,

- std::vector<std::string>* unhandled_permissions) override;

+ bool FromValue(const base::Value* value,

+ std::string* error,

+ std::vector<std::string>* unhandled_permissions) override;

// APIPermission overrides.

- virtual PermissionMessages GetMessages() const override;

+ PermissionMessages GetMessages() const override;

// Permission strings.

static const char kAllAutoDetectedPermission[];