extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h ('k') | extensions/browser/api/device_permissions_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

index 605d4740866664d958b0177029a99d529de4db00..5b14e21bf1d43dbccc048fbc3d66fcaa84b2eb61 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

+++ b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

@@ -95,20 +95,19 @@ class WebRequestRulesRegistry : public RulesRegistry {

bool crosses_incognito);

// Implementation of RulesRegistry:

- virtual std::string AddRulesImpl(

+ std::string AddRulesImpl(

const std::string& extension_id,

- const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) override;

- virtual std::string RemoveRulesImpl(

+ const std::vector<linked_ptr<RulesRegistry::Rule>>& rules) override;

+ std::string RemoveRulesImpl(

const std::string& extension_id,

const std::vector<std::string>& rule_identifiers) override;

- virtual std::string RemoveAllRulesImpl(

- const std::string& extension_id) override;

+ std::string RemoveAllRulesImpl(const std::string& extension_id) override;

// Returns true if this object retains no allocated data. Only for debugging.

bool IsEmpty() const;

protected:

- virtual ~WebRequestRulesRegistry();

+ ~WebRequestRulesRegistry() override;

// Virtual for testing:

virtual base::Time GetExtensionInstallationTime(