extensions/browser/guest_view/web_view/web_view_permission_helper.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_guest.h ('k') | extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_permission_helper.h

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.h b/extensions/browser/guest_view/web_view/web_view_permission_helper.h

index 075e24d08a7f1787d95e2e9df0c451541234696d..3ee66b1f49fa605d71c0afb82868f4fefa291e2c 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper.h

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.h

@@ -28,7 +28,7 @@ class WebViewPermissionHelper

: public content::WebContentsObserver {

public:

explicit WebViewPermissionHelper(WebViewGuest* guest);

- virtual ~WebViewPermissionHelper();

+ ~WebViewPermissionHelper() override;

typedef base::Callback<

void(bool /* allow */, const std::string& /* user_input */)>

PermissionResponseCallback;

@@ -142,10 +142,9 @@ class WebViewPermissionHelper

#if defined(ENABLE_PLUGINS)

// content::WebContentsObserver implementation.

- virtual bool OnMessageReceived(

- const IPC::Message& message,

- content::RenderFrameHost* render_frame_host) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message,

+ content::RenderFrameHost* render_frame_host) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

#endif // defined(ENABLE_PLUGINS)

// A counter to generate a unique request id for a permission request.